Bug#646273: itsol: FTBFS with -Werror=format-security

[Julian Taylor]

Source: itsol
Version:1.0.0-2
Severity: normal
User: debian-qa at lists.debian.org
Usertags: hardening-format-security hardening

the package itsol fails to compile with the new hardened compiler
flags dpkg-buildflag outputs [0].
The problematic flag is: -Werror=format-security
See the ubuntu buildlog:
https://launchpadlibrarian.net/83142471/buildlog_ubuntu-precise-i386.itsol_1.0.0-2_FAILEDTOBUILD.txt.gz
Snippet:
[ 65%] Building C object CMakeFiles/itsol.dir/LIB/sets.c.o
/tmp/itsol-1.0.0/LIB/sets.c: In function 'errexit':
/tmp/itsol-1.0.0/LIB/sets.c:19:3: error: format not a string literal and
no format arguments [-Werror=format-security]
cc1: some warnings being treated as errors


The buildflags are not exported in debian, but can be enabled e.g. by
adding this to debian/rules:

 DPKG_EXPORT_BUILDFLAGS = 1
 include /usr/share/dpkg/buildflags.mk

Please fix the issues and maybe also enable the hardened build in debian.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html







-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-science-maintainers/attachments/20111022/1625d148/attachment.pgp>