Bug#643416: libalberta2: FTBFS: ../Common/write_mesh_gmv.c:339:3: error: format not a string literal and no format arguments [-Werror=format-security]

[Didier Raboud]

Source: libalberta2
Version: 2.0.1-3.1
Severity: serious
Tags: wheezy sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> /bin/bash ../../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -DDIM_OF_WORLD=1 -DALBERTA_DEBUG=0 -I. -I../../.. -I./../0d -I./../1d -I./../2d -I./../3d -I./../Common   -I../../../alberta_util/src -I../../../alberta_util/src/  -I/usr/include  -Wall -O3 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -c -o write_mesh_gmv.lo `test -f '../Common/write_mesh_gmv.c' || echo './'`../Common/write_mesh_gmv.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -DDIM_OF_WORLD=1 -DALBERTA_DEBUG=0 -I. -I../../.. -I./../0d -I./../1d -I./../2d -I./../3d -I./../Common -I../../../alberta_util/src -I../../../alberta_util/src/ -I/usr/include -Wall -O3 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -c ../Common/write_mesh_gmv.c  -fPIC -DPIC -o .libs/write_mesh_gmv.o
> ../Common/write_mesh_gmv.c: In function 'add_drv':
> ../Common/write_mesh_gmv.c:339:3: error: format not a string literal and no format arguments [-Werror=format-security]
> ../Common/write_mesh_gmv.c:339:3: error: format not a string literal and no format arguments [-Werror=format-security]
> ../Common/write_mesh_gmv.c: In function 'add_drdv':
> ../Common/write_mesh_gmv.c:465:5: error: format not a string literal and no format arguments [-Werror=format-security]
> ../Common/write_mesh_gmv.c:465:5: error: format not a string literal and no format arguments [-Werror=format-security]
> ../Common/write_mesh_gmv.c: In function 'add_refined_data':
> ../Common/write_mesh_gmv.c:945:7: error: format not a string literal and no format arguments [-Werror=format-security]
> ../Common/write_mesh_gmv.c:945:7: error: format not a string literal and no format arguments [-Werror=format-security]
> ../Common/write_mesh_gmv.c:986:7: error: format not a string literal and no format arguments [-Werror=format-security]
> ../Common/write_mesh_gmv.c:986:7: error: format not a string literal and no format arguments [-Werror=format-security]
> cc1: some warnings being treated as errors
> 
> make[5]: *** [write_mesh_gmv.lo] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2011/09/23/libalberta2_2.0.1-3.1_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.