Bug#657789: python-tables: Enable bzip2 and lzo compressors

[Picca Frédéric-Emmanuel]

Le Mon, 30 Jan 2012 23:39:27 +0100,
Antonio Valentino <antonio.valentino at tiscali.it> a écrit :

> Hi Frédéric,
> 
> Il 29/01/2012 10:33, Picca Frédéric-Emmanuel ha scritto:
> > Package: python-tables
> > Version: 2.3.1-1
> > Followup-For: Bug #657789
> > 
> > Hello,
> > 
> > I saw your proposed patch.
> > 
> > +import platform
> > +
> > + # Using ``setuptools`` enables lots of goodies, such as building eggs.
> > + if 'FORCE_SETUPTOOLS' in os.environ:
> > +@@ -127,8 +128,14 @@
> > +     add_from_flags("LDFLAGS", "-L", default_library_dirs)
> > 
> > it seems that the upstream can add path provided from the LDFLAGS, so the best
> > thinks to do is to
> > use the multiarch [1] instead of patching the code.
> > 
> 
> Do you mean adding something like
> 
> LDFLAGS += -L/usr/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH)
> 
> in debian/rules?
> Yes it seems to be a solution by far cleaner.
> Thank you very much.

yes something like that with an export in front
export LDFLAGS ?= -L/usr/lib/$(shell dpkg-architecture -qDEB_HOST_MULTIARCH)

> 
> On the other end I would like do add a better support for multiarch
> systems upstream, an in that case I can't rely on dpkg-architecture.
> 
> Any idea on how to do it in a general and safe way?

usually pkg-config[1] is the solution for this sort of things. but I
check the lzo package and it doesn not provide the .pc file. Maybe I
should fill a but for thoses library without .pc files.
nevertheless the multiarch support is completly Debian specific for now...

So to my opinion, the pkg-config is the solution and when there is no pkg-config support of third party libraries.
Allow to use the LDFLAGS, CFLAGS for fine tuning.

I hope it answer you question :)

See you

Frederic

[1] http://www.freedesktop.org/wiki/Software/pkg-config


-- 
GPG public key 4096R/4696E015 2011-02-14
    fingerprint = E92E 7E6E 9E9D A6B1 AA31  39DC 5632 906F 4696 E015
uid  Picca Frédéric-Emmanuel <picca at synchrotron-soleil.fr>

GPG public key 1024D/A59B1171 2009-08-11
    fingerprint = 1688 A3D6 F0BD E4DF 2E6B  06AA B6A9 BA6A A59B 1171
uid  Picca Frédéric-Emmanuel <picca at debian.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-science-maintainers/attachments/20120131/92abbf8d/attachment.pgp>