Bug#662792: Bug#616928: openturns_0.15-2.1 NMU

[Jakub Wilk]

(I'm not the maintainer, just a neutral observer.)

* Aron Xu <happyaron.xu at gmail.com>, 2012-03-30, 18:44:
>I have prepared an NMU of openturns, uploaded to DELAYED/10 as version 
>0.15-2.1. Please contact me if you think the package should be 
>rescheduled or canceled.

Please note that as per Developer's Referene §5.11, “you must send a 
patch with the differences between the current package and your proposed 
NMU to the BTS.”

>   * Non-maintainer upload. (Closes: #662792).

OK.

>   * Getting rid of unneeded *.la (Closes: #622492).

OK.

>   * Transition to dh_python2 (Closes: #616928).

Presumably part of the “transition” is this:

--- openturns-0.15/debian/python-openturns.install	2012-03-30 15:14:22.000000000 +0200
+++ openturns-0.15/debian/python-openturns.install	2012-03-30 11:19:35.000000000 +0200
@@ -1,3 +1,2 @@
-debian/tmp/usr/lib/python*/*-packages/openturns/*.py
-debian/tmp/usr/lib/python*/*-packages/openturns/_*
-debian/tmp/usr/lib/python*/*-packages/openturns/openturns_preload*
+usr/lib/python*/*-packages/openturns/*.py usr/share/pyshared/openturns/
+usr/lib/python2.7/*-packages/openturns/*.so* usr/lib/pyshared/python2.7/openturns/

Why do you hardcode 2.7? This is almost certainly incorrect.

>   * Use dh rules.tiny,

This is not appropriate for an NMU.

>enable parallel build.

This is not appropriate for an NMU either, especially when you introduce 
new bugs:

- You use DEB_HOST_* variables without defining them.

- You use DEB_HOST_* variables though you really should use DEB_BUILD_* 
ones.

- If you really need to want know number of cores (why?), use “getconf 
_NPROCESSORS_ONLN” instead of parsing /proc/cpuinfo.

- You are not supposed to modify DEB_BUILD_OPTIONS in debian/rules...

- ...especially not when you modify it in such a way its value is not 
policy compliant anymore.


Now looking at the diff:

- You converted to source format 3.0 (quilt), which is not documented in 
the changelog.

- You bumped B-D on debhelper to >= 8, which is not documented.

- You added B-D on autoconf, which is not documented.

- You bumped S-V to 3.9.3, which is not documented.

- You dropped some Section fields from binary stanzas in debian/control, 
which is not documented.

- You removed debain/dirs, which is not documented.

- You stripped debian/tmp prefixes and made other cosmetic changes in 
debian/*.install files, which is not documented.

- You added “-Wl,--as-needed” to LDFLAGS, which is not documented.

- You ignore test failures. Why?

- /usr/lib/openturns/libOT.a is not installed anymore. Why? This is not 
documented.

- *.m4 files were moved from /usr/share/openturns/m4/m4/ to 
/usr/share/openturns/m4/. While use of the former path was arguably a 
bug, this is not documented.

- AUTHORS, README and TODO files are not installed anymore. Why? This is 
not documented.

- *.py files in openturns-examples are not bytecompiled anymore. This is 
not documented.

- libopenturns-dbg provides detached debugging information only for 
libopenturns0 (rather than for all packages as it used to). Why? This is 
not documented.

-- 
Jakub Wilk