Bug#693610: pointless strict hdf version check

[Julian Taylor]

reassign 693610 hdf5 1.8.9-1~exp1
severity 693610 serious
tags 693610 + experimental
thanks

hdf5 1.8.9 is not compatible with 1.8.8 as long as this check is in place.
Either the check should be relaxed, removed or the soversion bumped.
This kind of thing should be handled by soversion and not runtime <->
compile time checks, so removing the check completely might be the best
option.

attached a debdiff to relax the check to major.minor
-------------- next part --------------
diff -Nru hdf5-1.8.9/debian/changelog hdf5-1.8.9/debian/changelog
--- hdf5-1.8.9/debian/changelog	2012-09-30 17:40:53.000000000 +0200
+++ hdf5-1.8.9/debian/changelog	2012-11-18 17:36:33.000000000 +0100
@@ -1,3 +1,11 @@
+hdf5 (1.8.9-1~exp1ubuntu1) UNRELEASED; urgency=low
+
+  * relax-version-check.patch:
+    don't check the compile time patch version at runtime, this saves us
+    full transitions when it is still compatible.
+
+ -- Julian Taylor <jtaylor at ubuntu.com>  Sun, 18 Nov 2012 17:35:31 +0100
+
 hdf5 (1.8.9-1~exp1) experimental; urgency=low
 
   * New upstream release (Closes: #673788)
diff -Nru hdf5-1.8.9/debian/control hdf5-1.8.9/debian/control
--- hdf5-1.8.9/debian/control	2012-10-01 18:18:57.000000000 +0200
+++ hdf5-1.8.9/debian/control	2012-11-18 17:36:44.000000000 +0100
@@ -1,7 +1,8 @@
 Source: hdf5
 Section: science
 Priority: optional
-Maintainer: Debian GIS Project <pkg-grass-devel at lists.alioth.debian.org>
+Maintainer: Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>
+XSBC-Original-Maintainer: Debian GIS Project <pkg-grass-devel at lists.alioth.debian.org>
 Uploaders: Francesco Paolo Lovergine <frankie at debian.org>,
  Sylvestre Ledru <sylvestre at debian.org>
 Build-Depends: dpkg-dev (>= 1.16.1~), libmpich2-dev, zlib1g-dev,
diff -Nru hdf5-1.8.9/debian/control.in hdf5-1.8.9/debian/control.in
--- hdf5-1.8.9/debian/control.in	2012-10-01 18:16:36.000000000 +0200
+++ hdf5-1.8.9/debian/control.in	2012-11-18 17:36:42.000000000 +0100
@@ -1,7 +1,8 @@
 Source: hdf5
 Section: science
 Priority: optional
-Maintainer: Debian GIS Project <pkg-grass-devel at lists.alioth.debian.org>
+Maintainer: Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>
+XSBC-Original-Maintainer: Debian GIS Project <pkg-grass-devel at lists.alioth.debian.org>
 Uploaders: Francesco Paolo Lovergine <frankie at debian.org>,
  Sylvestre Ledru <sylvestre at debian.org>
 Build-Depends: dpkg-dev (>= 1.16.1~), libmpich2-dev, zlib1g-dev,
diff -Nru hdf5-1.8.9/debian/patches/relax-version-check.patch hdf5-1.8.9/debian/patches/relax-version-check.patch
--- hdf5-1.8.9/debian/patches/relax-version-check.patch	1970-01-01 01:00:00.000000000 +0100
+++ hdf5-1.8.9/debian/patches/relax-version-check.patch	2012-11-18 17:33:57.000000000 +0100
@@ -0,0 +1,20 @@
+Description: remove check on patch version
+ hopefully changes in that number always are compatible.
+ Without this every bugfix update would require a full transition as it will
+ abort when the version does not match exactly.
+ The version check will be executed with compile time values on every file
+ access see e.g. H5F_ACC_RDONLY in src/H5Fpublic.h
+Author: Julian Taylor <jtaylor at ubuntu.com>
+
+--- a/src/H5.c
++++ b/src/H5.c
+@@ -665,8 +665,7 @@
+             disable_version_check = (unsigned int)HDstrtol (s, NULL, 0);
+     }
+ 
+-    if (H5_VERS_MAJOR!=majnum || H5_VERS_MINOR!=minnum ||
+-            H5_VERS_RELEASE!=relnum) {
++    if (H5_VERS_MAJOR!=majnum || H5_VERS_MINOR!=minnum) {
+         switch (disable_version_check) {
+ 	case 0:
+ 	    HDfprintf(stderr, "%s%s", version_mismatch_warning,
diff -Nru hdf5-1.8.9/debian/patches/series hdf5-1.8.9/debian/patches/series
--- hdf5-1.8.9/debian/patches/series	2012-06-14 17:42:44.000000000 +0200
+++ hdf5-1.8.9/debian/patches/series	2012-11-18 17:30:34.000000000 +0100
@@ -1,3 +1,4 @@
 mpi.diff
 path_max.diff
 ullong_force.diff
+relax-version-check.patch