Bug#683226: mpich2: Segfaults if ssh is not available

[Michael Banck]

Hi,

On Fri, Apr 12, 2013 at 01:15:55PM +0200, Lucas Nussbaum wrote:
> On 12/04/13 at 12:40 +0200, Michael Banck wrote:
> > # <azeem> heya, any opinion whether #683226 should be RC (and fixed
> > #         for wheezy)?
> > # <Q_> azeem_: I see no reason for it not being RC.
> > 
> > severity 683226 serious
> > tags 683226 +pending
> > thanks
> > 
> > I will NMU this then.
> 
> Thanks a lot. Please NMU without delay.

Uploaded, the debdiff is attached.


Cheeers,

Michael
-------------- next part --------------
diff -Nru mpich2-1.4.1/debian/changelog mpich2-1.4.1/debian/changelog
--- mpich2-1.4.1/debian/changelog	2012-12-17 02:06:08.000000000 +0100
+++ mpich2-1.4.1/debian/changelog	2013-04-12 13:58:16.000000000 +0200
@@ -1,3 +1,12 @@
+mpich2 (1.4.1-4.2) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * debian/patches/fix_segfault.patch: New patch, fixes a segfault in
+    HYDU_get_abs_wd() if the requested executable is not available, taken from
+    upstream changeset 8d5444. Closes: #683226, #683217.
+
+ -- Michael Banck <mbanck at debian.org>  Fri, 12 Apr 2013 13:46:26 +0200
+
 mpich2 (1.4.1-4.1) unstable; urgency=low
 
   * Non-maintainer upload.
diff -Nru mpich2-1.4.1/debian/patches/fix_segfault.patch mpich2-1.4.1/debian/patches/fix_segfault.patch
--- mpich2-1.4.1/debian/patches/fix_segfault.patch	1970-01-01 01:00:00.000000000 +0100
+++ mpich2-1.4.1/debian/patches/fix_segfault.patch	2013-04-12 13:43:51.000000000 +0200
@@ -0,0 +1,12 @@
+--- mpich2-1.4.1.orig/src/pm/hydra/utils/args/args.c
++++ mpich2-1.4.1/src/pm/hydra/utils/args/args.c
+@@ -226,6 +226,9 @@ char *HYDU_get_abs_wd(const char *wd)
+ {
+     char *cwd, *retdir;
+ 
++    if (wd == NULL)
++        return NULL;
++
+     if (wd[0] != '.')
+         return (char *) wd;
+ 
diff -Nru mpich2-1.4.1/debian/patches/series mpich2-1.4.1/debian/patches/series
--- mpich2-1.4.1/debian/patches/series	2012-01-16 03:22:50.000000000 +0100
+++ mpich2-1.4.1/debian/patches/series	2013-04-12 13:57:08.000000000 +0200
@@ -1,2 +1,3 @@
 destdir.patch
 link-libs.patch
+fix_segfault.patch