Bug#733679: wcslib: ensure that configure never runs before autoreconf

[Colin Watson]

Package: wcslib
Version: 4.20-1
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch trusty

Hi,

Thanks for arranging to update config.guess and config.sub for new ports
in 4.19-3!  However, it doesn't quite work in practice, because more or
less the first thing dpkg-buildpackage tries to do is to clean the tree,
and this fails as follows:

     dh_auto_clean
  make[1]: Entering directory `/build/buildd/wcslib-4.20'
  GNUmakefile:38: makedefs: No such file or directory
  
  Thu 2013/12/19 03:09:11 +0000, executing on 
  
  Environment variables that affect 'configure':
    CC       = (undefined)
    CFLAGS   = -g -O2 -Wformat -Werror=format-security
    CPP      = (undefined)
    CPPFLAGS = -D_FORTIFY_SOURCE=2
    F77      = (undefined)
    FFLAGS   = -g -O2
    LDFLAGS  = -Wl,-Bsymbolic-functions -Wl,-z,relro
  
  ./configure --no-create
  checking build system type... config/config.guess: unable to guess system type
  [...]

To avoid this, I think it would be best to run dh_auto_clean only if
makedefs exists.  Here's a patch for that.

  * Don't run dh_auto_clean if makedefs doesn't exist, since that would end
    up running configure before autoreconf has been run and thus fail on new
    ports.

diff -Nru wcslib-4.20/debian/rules wcslib-4.20/debian/rules
--- wcslib-4.20/debian/rules	2013-12-18 11:05:19.000000000 +0000
+++ wcslib-4.20/debian/rules	2013-12-30 16:39:42.000000000 +0000
@@ -6,6 +6,9 @@
 %:
 	dh  $@ --with autoreconf,autotools_dev
 
+override_dh_auto_clean:
+	[ ! -e makedefs ] || dh_auto_clean
+
 override_dh_autoreconf:
 	AUTOHEADER=true dh_autoreconf
 

Thanks,

-- 
Colin Watson                                       [cjwatson at ubuntu.com]