Bug#699717: arduino-mk: User libraries not picked up by make

[John Kozak]

Package: arduino-mk
Version: 0.8-4
Severity: normal

Dear Maintainer,

The arduino-mk build system does not pick up user libraries correctly.
This is because of the following bug in /usr/share/arduino/Arduino.mk:

USER_LIB_CPP_SRC   = $(wildcard $(patsubst %,%/*.cpp,$(USER_LIBS)))
USER_LIB_C_SRC     = $(wildcard $(patsubst %,%/*.c,$(USER_LIBS)))
LIB_OBJS      = $(patsubst $(ARDUINO_LIB_PATH)/%.c,$(OBJDIR)/libs/%.o,$(LIB_C_SRCS)) \
		$(patsubst $(ARDUINO_LIB_PATH)/%.cpp,$(OBJDIR)/libs/%.o,$(LIB_CPP_SRCS)) \
		$(patsubst $(USER_LIB_PATH)/%.cpp,$(OBJDIR)/libs/%.o,$(USER_LIB_CPP_SRCS)) \
		$(patsubst $(USER_LIB_PATH)/%.c,$(OBJDIR)/libs/%.o,$(USER_LIB_C_SRCS))

I believe that the two USER_LIB defines should be replaced by these:

USER_LIB_CPP_SRCS   = $(wildcard $(patsubst %,%/*.cpp,$(USER_LIBS)))
USER_LIB_C_SRCS     = $(wildcard $(patsubst %,%/*.c,$(USER_LIBS)))

to be picked up by LIB_OBJS below.


-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages arduino-mk depends on:
ii  arduino-core         1:1.0.1+dfsg-7
ii  libconfig-yaml-perl  1.42-2        
ii  perl-doc             5.14.2-15     

arduino-mk recommends no packages.

arduino-mk suggests no packages.

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/arduino/Arduino.mk (from arduino-mk package)

-- 
John