Bug#715286: mpich: maintainer scripts assume #DEBHELPER# only sometimes does something

[Ansgar Burchardt]

Source: mpich
Version: 1.2.7-10

Several maintainer scripts in mpich follow this pattern:

----
#!/bin/sh
set -e

case "$1" in
   configure)
      # Continue below
      ;;
   abort-upgrade|abort-remove|abort-deconfigure)
      exit 0;
      ;;
   *)
      echo "postinst called with unknown argument \`$1'" >&2
      exit 0;
      ;;
esac

[do-something]

#DEBHELPER#
----

This assumes that #DEBHELPER# will only ever do something when the
maintainer script is called with $1 = configure.

They should probably follow

----
#!/bin/sh
set -e

if [ "$1" = configure ]; then
  [do-something]
fi

#DEBHELPER#
----

Ansgar