Bug#764904: apophenia: FTBFS - test suite times out or has unexpected failures

[Edmund Grimley Evans]

>From the buildd logs it appears that the tests are timing out.

A quick look at apop_conversions.c suggests a plausible explanation.

In that file there is code like this:

    char c = fgetc(infile);
...
    while(c!='\n' && c !=EOF){

EOF is negative, and plain char is unsigned on ARM architectures, so
c !=EOF will always be true.

Every use of EOF in that file seems to suffer from the same problem.

The fragment above could probably be fixed just by changing "char" to
"int". In other places the fix is less trivial because the code is
trying to store EOF into an array of char, for example.

This might explain the test failures: it spins forever reading EOF but
not recognising it as EOF.