Bug#806876: visp: FTBFS when built with dpkg-buildpackage -A (143 tests failed out of 143)

[Santiago Vila]

On Thu, Dec 03, 2015 at 02:05:26PM +0100, Fabien Spindler wrote:
> On 02/12/2015 16:50, Santiago Vila wrote:
> >So, maybe a target "override_dh_auto_test-indep" that does not do anything
> >would fix this. Thanks.
> Doesn't work if I rename "override_dh_auto_test" into
> "override_dh_auto_test-indep".

That's really the opposite of what we want. We want the tests not to
run at all when we are creating the arch-independent packages.

> Doesn't work if I introduce "override_dh_auto_test-indep" that does nothing
> and keep "override_dh_auto_test" as it is.

That's because the mere existence of override_dh_auto_test-indep,
apparently, does not invalidate override_dh_auto_test.
(I have just done a few tests with an almost dummy package).

> The solution I found is to rename "override_dh_auto_test" into
> "override_dh_auto_test-arch" to make testing arch dependent.
> 
> override_dh_auto_test-arch:
> export VISP_INPUT_IMAGE_PATH=/usr/share/visp-images-data/ \
> && dh_auto_test --max-parallel=1 || ${DH_AUTOTEST_CAN_FAIL}
> 
> I'm not expert, so I don't know if this is the right way to disable testing
> using dpkg-buildpackage -A

As far as it works as intended, it would be right.

But to be safe, I would drop the current override_dh_auto_test, as you
did, and would put both -arch and -indep to replace them:

override_dh_auto_test-indep:

override_dh_auto_test-arch:
	your current code

If you only use override_dh_auto_test-arch, it will do dh_auto_test
anyway when building arch-independent packages, since it's not
overridden. It will not do anything because VISP_INPUT_IMAGE_PATH
is not defined, but I think it's better that it does not even try,
hence my suggestion to put an empty override_dh_auto_test-indep.

Thanks.