Bug#808791: gummi: May ship in invalid directories after autoreconf

[Mathieu Trudel-Lapierre]

Package: gummi
Version: 0.6.5-6
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu xenial ubuntu-patch

Dear Maintainer,

In Ubuntu, I've noticed that gummi tries to ship locale files in
the /usr/@DATADIRNAME@ directory, litterally.

Now, I haven't done much background investigation on this, and I suspect
it is failing in Ubuntu and not currently happening in Debian because of a
difference in the toolchain package versions.

What happens precisely is that rather than correctly replacing @DATADIRNAME@
with 'share', the value is kept unreplaced. It should be sufficient to replace
uses of $(prefix)/$(DATADIRNAME) with $(datadir).

In any case, I'm including a patch for your convenience, since I expect some
time in the future gummi may catch the same issue in Debian.

If such an occurence does happen, you'll notice lintian warnings too:
W: gummi: non-standard-dir-in-usr usr/@DATADIRNAME@/
W: gummi: file-in-unusual-dir usr/@DATADIRNAME@/locale/ar/LC_MESSAGES/gummi.mo
W: gummi: file-in-unusual-dir usr/@DATADIRNAME@/locale/ca/LC_MESSAGES/gummi.mo
W: gummi: file-in-unusual-dir usr/@DATADIRNAME@/locale/cs/LC_MESSAGES/gummi.mo
W: gummi: file-in-unusual-dir usr/@DATADIRNAME@/locale/da/LC_MESSAGES/gummi.mo
W: gummi: file-in-unusual-dir usr/@DATADIRNAME@/locale/de/LC_MESSAGES/gummi.mo
[...]

*** /tmp/tmpcMIZb0/bug_body

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/upgrade_datadir.patch: replace outdated uses of
    $(DATADIRNAME) with $(datadir).


Thanks for considering the patch.


-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 'xenial'), (100, 'xenial-backports'), (99, 'xenial-proposed')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-19-generic (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gummi_0.6.5-6ubuntu1.debdiff
Type: text/x-diff
Size: 1319 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-science-maintainers/attachments/20151222/b13cac1c/attachment.diff>