Bug#798024: typo in clblas-ppc64el patch ?

Ansgar Burchardt ansgar at debian.org
Tue Sep 15 08:24:00 UTC 2015


Ghislain Vaillant <ghisvail at gmail.com> writes:
> In the patch you provided, d/rules is modified with:
>
>  # Uncomment this to turn on verbose mode.
>  #export DH_VERBOSE=1
>
> +DEB_HOST_ARCH=$(shell dpkg-architecture -qDEB_HOST_ARCH)
> +
>  export DEB_BUILD_MAINT_OPTIONS = hardening=+all
>  export DEB_CFLAGS_MAINT_APPEND = -Wall -pedantic
>  export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
>
> +ifeq ($(DEB_BUILD_ARCH), ppc64el)
> +DEB_CFLAGS_MAINT_APPEND += -mno-altivec
> +endif
> +
>  %:
>  	dh $@ --sourcedirectory=src \
>  		--buildsystem=cmake \
>
> Isn't it s/DEB_HOST_ARCH/DEB_BUILD_ARCH at the beginning?

I think it should be DEB_HOST_ARCH (also below).
>From man:dpkg-architecture(1):

| build machine: The machine the package is built on.
| host machine: The machine the package is built for.

and I assume this is not for some helper programs intended to be run as
part of the build (on the build machine), but for the binaries that
should end up in the package.

Ansgar



More information about the debian-science-maintainers mailing list