Bug#817033: FTBFS randomly. Missing build-depends on python-matplotlib

[Santiago Vila]

retitle 817033 sumo: FTBFS randomly. Missing build-depends on python-matplotlib
user sanvila at debian.org
usertags 817033 - binary-indep
severity 817033 serious
tags 817033 + patch
thanks

Dear maintainer: Because this error happens in the build stage, not in
the package creation stage, this is not really a "FTBFS when using
dpkg-buildpackage -A" bug, but a normal FTBFS bug. I'm therefore
raising the severity accordingly.

There are actually two different bugs here. One of them is that some
documentation seems to require the matplotlib library being present
to be built.

The other is that the Makefile does not properly check for errors.
This is a violation of Policy 4.6, "Error trapping in makefiles".

I believe the attached patch might fix both bugs, but I have not
tested it. Please give it a try.

BTW: You might want to forward this bug upstream as it is an upstream bug
in the Makefile.

Thanks.
-------------- next part --------------
diff --git a/Makefile.am b/Makefile.am
index 9eb89c2..38be892 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -7,10 +7,7 @@ doc: pydoc doxygen userdoc javadoc
 pydoc:
 	rm -rf docs/pydoc
 	mkdir docs/pydoc
-	cd docs/pydoc && \
-	for i in `find ../../tools/traci ../../tools/sumolib -name "*.py" -not -executable | sed 's,../../tools/,,;s,/,.,g;s,.py,,;s,.__init__,,'`; do \
-	    PYTHONPATH="../../tools" python -c "import $$i, pydoc; pydoc.writedoc($$i)"; \
-	done
+	cd docs/pydoc && sh ../../mk-pydoc
 
 doxygen:
 	rm -rf docs/doxygen
diff --git a/debian/control b/debian/control
index fe25e87..ae31a21 100644
--- a/debian/control
+++ b/debian/control
@@ -19,7 +19,8 @@ Build-Depends: autotools-dev,
                libxerces-c-dev,
                libxrandr-dev
 Build-Depends-Indep: doxygen,
-                     python
+                     python,
+                     python-matplotlib
 Standards-Version: 3.9.6
 Vcs-Browser: https://anonscm.debian.org/cgit/debian-science/packages/sumo.git
 Vcs-Git: git://anonscm.debian.org/debian-science/packages/sumo.git
diff --git a/mk-pydoc b/mk-pydoc
new file mode 100644
index 0000000..739e3e0
--- /dev/null
+++ b/mk-pydoc
@@ -0,0 +1,5 @@
+#!/bin/sh
+set -e
+for i in `find ../../tools/traci ../../tools/sumolib -name "*.py" -not -executable | sed 's,../../tools/,,;s,/,.,g;s,.py,,;s,.__init__,,'`; do
+  PYTHONPATH="../../tools" python -c "import $i, pydoc; pydoc.writedoc($i)"
+done