Bug#833383: ros-std-msgs: split headers and message definitions

Jochen Sprickerhof debian-bts at jochen.sprickerhof.de
Wed Aug 10 20:06:51 UTC 2016


Hi Daniele,

* Daniele E. Domenichelli <ddomenichelli at drdanz.it> [2016-08-10 15:19]:
> Thanks! I replied to the comments on github, anyway I'm reporting the
> everything here:

Great, let's move it all over here.

> It would be useful to be able to do something similar anyway, perhaps
> find_package(std_msgs COMPONENTS messages), but I think the CMake files
> are generated and are supposed to be used with catkin and I don't know
> much about it. Suggestions?
> 
> Perhaps I'll just add a Findstd_msgs.cmake to my projects...

(old comment)
Why would you use cmake to find the messages? I would propose to just
keep them in the canonical directory. Otherwise +1.

* Daniele E. Domenichelli <notifications at github.com> [2016-08-10 08:45]:
> In my CMake project, I would like to do something like this:
> 
> ```cmake
>  find_package(std_msgs REQUIRED)
>  generate_bindings("${std_msgs_MSG_DIR}/std_msgs/String.msg")
> ```

Why not use $CMAKE_INSTALL_DATAROOTDIR or
$CATKIN_GLOBAL_SHARE_DESTINATION? I don't think we need an extra
find*.cmake.

> Attached you will find the 2nd version of the patch.
> I moved the CMake files and the package.xml files back to the original
> package, removed the dependencies, and reverted the changes to the
> changelog file.

Looking great from my side. Maybe we will need some more dependencies
(or recommends) on this package, like for rosmsg for example and we
should add it to the ros-core-dev meta package. What do you think?

> Actually I'm already registered and member of the debian-science group,
> I'm not sure of which permissions I have on the repositories though.
> perhaps when the patch is ready I can try pushing it...

That's great, you should be able to push this, feel free do go ahead :).

Cheers Jochen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-science-maintainers/attachments/20160810/af69ef12/attachment-0001.sig>


More information about the debian-science-maintainers mailing list