Bug#834982: sdformat: FTBFS in testing ('_link' has incomplete type)

[Santiago Vila]

Package: src:sdformat
Version: 4.1.0-1
Severity: serious

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
(which is what the "Arch: all" autobuilder would do to build it)
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --parallel
   dh_testdir -i -O--parallel
   dh_update_autotools_config -i -O--parallel
   debian/rules override_dh_auto_configure
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_configure -- \
            -DUSE_EXTERNAL_URDF:BOOL=True \
            -DUSE_UPSTREAM_CFLAGS:BOOL=False \
            -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo
	cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_SYSCONFDIR=/etc -DCMAKE_INSTALL_LOCALSTATEDIR=/var -DUSE_EXTERNAL_URDF:BOOL=True -DUSE_UPSTREAM_CFLAGS:BOOL=False -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo
-- The C compiler identification is GNU 6.1.1
-- The CXX compiler identification is GNU 6.1.1

[... snipped ...]

     class shared_ptr;
           ^~~~~~~~~~
/<<PKGBUILDDIR>>/src/parser_urdf.cc: In function 'void ReduceSDFExtensionJointFrameReplace(std::vector<std::shared_ptr<TiXmlElement> >::iterator, UrdfLinkPtr)':
/<<PKGBUILDDIR>>/src/parser_urdf.cc:3832:17: error: '_link' has incomplete type
     UrdfLinkPtr _link)
                 ^~~~~
In file included from /usr/include/boost/throw_exception.hpp:42:0,
                 from /usr/include/boost/lexical_cast/bad_lexical_cast.hpp:28,
                 from /usr/include/boost/lexical_cast.hpp:31,
                 from /<<PKGBUILDDIR>>/include/sdf/Param.hh:23,
                 from /<<PKGBUILDDIR>>/include/sdf/Element.hh:24,
                 from /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/include/sdf/sdf.hh:5,
                 from /<<PKGBUILDDIR>>/src/parser_urdf.cc:31:
/usr/include/boost/exception/exception.hpp:148:11: note: declaration of 'UrdfLinkPtr {aka class boost::shared_ptr<urdf::Link>}'
     class shared_ptr;
           ^~~~~~~~~~
In file included from /usr/include/c++/6/bits/stl_algobase.h:67:0,
                 from /usr/include/c++/6/bits/char_traits.h:39,
                 from /usr/include/c++/6/ios:40,
                 from /usr/include/c++/6/istream:38,
                 from /usr/include/c++/6/fstream:38,
                 from /<<PKGBUILDDIR>>/src/parser_urdf.cc:17:
/usr/include/c++/6/bits/stl_iterator.h: In instantiation of '__gnu_cxx::__normal_iterator<_Iterator, _Container>& __gnu_cxx::__normal_iterator<_Iterator, _Container>::operator++() [with _Iterator = boost::shared_ptr<urdf::Visual>*; _Container = std::vector<boost::shared_ptr<urdf::Visual> >]':
/<<PKGBUILDDIR>>/src/parser_urdf.cc:995:48:   required from here
/usr/include/c++/6/bits/stl_iterator.h:792:2: error: cannot increment a pointer to incomplete type 'boost::shared_ptr<urdf::Visual>'
  ++_M_current;
  ^~~~~~~~~~~~
/usr/include/c++/6/bits/stl_iterator.h: In instantiation of '__gnu_cxx::__normal_iterator<_Iterator, _Container>& __gnu_cxx::__normal_iterator<_Iterator, _Container>::operator++() [with _Iterator = boost::shared_ptr<urdf::Collision>*; _Container = std::vector<boost::shared_ptr<urdf::Collision> >]':
/<<PKGBUILDDIR>>/src/parser_urdf.cc:1110:54:   required from here
/usr/include/c++/6/bits/stl_iterator.h:792:2: error: cannot increment a pointer to incomplete type 'boost::shared_ptr<urdf::Collision>'
/usr/include/c++/6/bits/stl_iterator.h: In instantiation of '__gnu_cxx::__normal_iterator<_Iterator, _Container>& __gnu_cxx::__normal_iterator<_Iterator, _Container>::operator++() [with _Iterator = const boost::shared_ptr<urdf::Collision>*; _Container = std::vector<boost::shared_ptr<urdf::Collision> >]':
/<<PKGBUILDDIR>>/src/parser_urdf.cc:2985:9:   required from here
/usr/include/c++/6/bits/stl_iterator.h:792:2: error: cannot increment a pointer to incomplete type 'const boost::shared_ptr<urdf::Collision>'
/usr/include/c++/6/bits/stl_iterator.h: In instantiation of '__gnu_cxx::__normal_iterator<_Iterator, _Container>& __gnu_cxx::__normal_iterator<_Iterator, _Container>::operator++() [with _Iterator = const boost::shared_ptr<urdf::Visual>*; _Container = std::vector<boost::shared_ptr<urdf::Visual> >]':
/<<PKGBUILDDIR>>/src/parser_urdf.cc:3107:9:   required from here
/usr/include/c++/6/bits/stl_iterator.h:792:2: error: cannot increment a pointer to incomplete type 'const boost::shared_ptr<urdf::Visual>'
/usr/include/c++/6/bits/stl_iterator.h: In instantiation of '__gnu_cxx::__normal_iterator<_Iterator, _Container>& __gnu_cxx::__normal_iterator<_Iterator, _Container>::operator++() [with _Iterator = const boost::shared_ptr<urdf::Link>*; _Container = std::vector<boost::shared_ptr<urdf::Link> >]':
/<<PKGBUILDDIR>>/src/parser_urdf.cc:3449:49:   required from here
/usr/include/c++/6/bits/stl_iterator.h:792:2: error: cannot increment a pointer to incomplete type 'const boost::shared_ptr<urdf::Link>'
src/CMakeFiles/sdformat.dir/build.make:209: recipe for target 'src/CMakeFiles/sdformat.dir/parser_urdf.cc.o' failed
make[3]: *** [src/CMakeFiles/sdformat.dir/parser_urdf.cc.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
CMakeFiles/Makefile2:1196: recipe for target 'src/CMakeFiles/sdformat.dir/all' failed
make[2]: *** [src/CMakeFiles/sdformat.dir/all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
Makefile:163: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
dh_auto_install: make -j1 install DESTDIR=/<<PKGBUILDDIR>>/debian/tmp AM_UPDATE_INFO_DIR=no returned exit code 2
debian/rules:26: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
--------------------------------------------------------------------------------

This failure is not really related to using "dpkg-buildpackage -A".
There are also build logs available here:

https://tests.reproducible-builds.org/debian/reproducible.html

Thanks.