Bug#812995: yorick-ynfft: FTBFS with libnfft version 3.3

[Gianfranco Costamagna]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Thibaut and Debian Science maintainers,

I did a little patch to fix the build failure, but now there is a
testsuite failure:

here the patch

- --- yorick-ynfft-1.0.2.orig/yor_nfft.c
+++ yorick-ynfft-1.0.2/yor_nfft.c
@@ -312,7 +312,7 @@ struct _op {
 #define GET_INP_DIMS(op)        ((op)->plan.N)
 #define GET_OVR_DIMS(op)        ((op)->plan.n)
 #define GET_OVR_FACT(op)        ((op)->plan.sigma)
- -#define GET_NFFT_FLAGS(op)      ((op)->plan.nfft_flags)
+#define GET_NFFT_FLAGS(op)      ((op)->plan.flags)
 #define GET_FFTW_FLAGS(op)      ((op)->plan.fftw_flags)
 #define GET_CUTOFF(op)          ((op)->plan.m)
 #define GET_NEVALS(op)          ((op)->nevals)
@@ -1013,7 +1013,7 @@ static void make_nfft_plan(nfft_plan *pl
   }

   /* Precompute interpolation weights. */
- -  if ((plan->nfft_flags & PRE_ONE_PSI) != 0) {
+  if ((plan->flags & PRE_ONE_PSI) != 0) {
     nfft_precompute_one_psi(plan);
   }
   return;

basically nfft_flags has been renamed in flags.

the testsuite failure is:
make[1]: Entering directory '/build/yorick-ynfft-1.0.2'
/usr/bin/make tests
make[2]: Entering directory '/build/yorick-ynfft-1.0.2'
/usr/lib/yorick/bin/yorick -batch nfft-tests.i
1-D transform (A0 vs. A1): SUCCESS
  - absolute error: max. = 1.9e-14, RMS = 3.9e-15
1-D transform (A1 vs. A2): SUCCESS
  - absolute error: max. = 1.2e-15, RMS = 2.8e-16

ERROR (nfft_full_matrix) length must be a strictly positive even number
  LINE: 272  FILE: /build/yorick-ynfft-1.0.2/nfft.i
yorick: quitting on error in batch mode
Makefile:97: recipe for target 'tests' failed
make[2]: *** [tests] Error 1
make[2]: Leaving directory '/build/yorick-ynfft-1.0.2'
debian/rules:27: recipe for target 'override_dh_auto_test' failed


and I'm not sure what does it mean.

do you have any clue?

cheers,

Gianfranco

On Thu, 28 Jan 2016 12:37:48 +0000 Ghislain Antony Vaillant
<ghisvail at gmail.com> wrote:
> Package: yorick-ynfft Version: 1.0.2-2 Severity: important
> 
> Dear Maintainer,
> 
> This source package fails to build with the latest release of
> libnfft available in experimental. The relevant portion of the
> build log is available below.
> 
> Version 3.3 introduced some API breaking changes in the signature
> of the public structures.
> 
> ``` cc -I. -DVERSION=\"1.0.2\" -Wdate-time -D_FORTIFY_SOURCE=2  -g
> -O2 -fstack-protector-strong -Wformat -Werror=format-security
> -Wdate-time -D_FORTIFY_SOURCE=2  -fPIC -DPLUG_IN -I.
> -I/usr/lib/yorick/include -o yor_nfft.o -c yor_nfft.c yor_nfft.c:
> In function 'op_eval': yor_nfft.c:380:12: warning: assignment from
> incompatible pointer type [-Wincompatible-pointer-types] inp_dims =
> GET_INP_DIMS(op); ^ yor_nfft.c: In function 'op_extract': 
> yor_nfft.c:313:33: warning: initialization from incompatible
> pointer type [-Wincompatible-pointer-types] #define
> GET_OVR_DIMS(op)        ((op)->plan.n) ^ yor_nfft.c:448:22: note:
> in expansion of macro 'GET_OVR_DIMS' const int *src =
> GET_OVR_DIMS(op); ^ yor_nfft.c:312:33: warning: initialization from
> incompatible pointer type [-Wincompatible-pointer-types] #define
> GET_INP_DIMS(op)        ((op)->plan.N) ^ yor_nfft.c:459:22: note:
> in expansion of macro 'GET_INP_DIMS' const int *src =
> GET_INP_DIMS(op); ^ yor_nfft.c:315:44: error: 'nfft_plan {aka
> struct <anonymous>}' has no member named 'nfft_flags' #define
> GET_NFFT_FLAGS(op)      ((op)->plan.nfft_flags) ^ 
> yor_nfft.c:500:27: note: in expansion of macro 'GET_NFFT_FLAGS' int
> value = get_flags(GET_NFFT_FLAGS(op), GET_FFTW_FLAGS(op)); ^ 
> yor_nfft.c:315:44: error: 'nfft_plan {aka struct <anonymous>}' has
> no member named 'nfft_flags' #define GET_NFFT_FLAGS(op)
> ((op)->plan.nfft_flags) ^ yor_nfft.c:503:17: note: in expansion of
> macro 'GET_NFFT_FLAGS' int value = GET_NFFT_FLAGS(op); ^ 
> yor_nfft.c: In function 'make_nfft_plan': yor_nfft.c:1016:12:
> error: 'nfft_plan {aka struct <anonymous>}' has no member named
> 'nfft_flags' if ((plan->nfft_flags & PRE_ONE_PSI) != 0) { ```
> 
> -- System Information: Debian Release: stretch/sid APT prefers
> testing APT policy: (500, 'testing'), (2, 'unstable'), (1,
> 'experimental') Architecture: amd64 (x86_64) Foreign Architectures:
> i386
> 
> Kernel: Linux 4.3.0-1-amd64 (SMP w/4 CPU cores) Locale:
> LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell:
> /bin/sh linked to /bin/dash Init: systemd (via
> /run/systemd/system)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWuOo3AAoJEPNPCXROn13ZWQ4P/Ax0NS7aK0l20yCbxb0ljHj6
o7mWX7YvyIiUStZod5mByDHXJPimxEw89GkjcB/5XliYjZnv/OgNJiaTJkWZ/ERo
12POS3hbgpM30b3QiavsosrD8O8dCGY4rQyU4VST05flGpo16ENiieeHavUe2eL5
CnslkG1x8jGVN6aEnEUjEzdL775TvQe9FigvugGqEcp1s6A1bdF5ZaZsJhbH99bO
lUzX5UCS13GpdASQO5kvVGANFsVqR51xgrcL6jnatAA+Q3wcvHbJwM++SoaKO+Pd
qt5opAfwPzG+LoLPJrjbjxHRWdr10/yTCZVEfjnMY1D0s41hujWZuWCX+mIMU0qT
52V0IYtk42g31dYqULpiXZyppZdMdm2snfdcpL+A2qeKNeWQIaw35IxAGyXzBzFk
rYWYm6+mdzljtlFXO04WDnEhLuIFei+j8DfH1kKOdmCbDDyj3X90pw3BB9V//8W2
2ot55w2RoJEVn79V8SkwPLVMIE6W/+PkGomrSDjcu7Q57dVDBsNSwyGIHyJJ5TXZ
YPxl0pbE9p9oBIbi86+T5Ni75f+Ql/KX+PK3dzobHW1TV6u0N8D1tgYKSNzXn/CE
jRdqGfcXNT7ScTQpDMyJnoT1LEXl2EPuUBaOQr0aPTP/aXLGXwoH7O8fmgPE9zM0
Wpy15OfoZ0hI2Oj0Utv0
=9MsM
-----END PGP SIGNATURE-----