Bug#812716: openmx: YOUSO10 defined with varying values, causing conflicting array sizes

[Michael Tautschnig]

Package: openmx
Version: 3.7.6-1
Usertags: goto-cc

During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.

file tran_variables.h line 19: error: conflicting array sizes for variable `TRAN_hksoutfilename'
old definition in module `openmx' file tran_variables.h line 19
char [500l]
new definition in module `TRAN_Allocate' file tran_variables.h line 19
char [100l]

makefile:212: recipe for target 'openmx' failed
make[1]: *** [openmx] Error 1
make[1]: Leaving directory '/srv/jenkins-slave/workspace/sid-goto-cc-openmx/openmx-3.7.6/source'
dh_auto_build: make -j1 returned exit code 2

It seems that the value of YOUSO10 is being set in various places, sometimes to
100 (which is also the fall-back in case it is not defined), but also to 500
(e.g., in source/openmx_common.h). The linker will make some decision (likely it
will pick the largest one), but the compiler will be limited to the information
local to the translation unit. It may choose to perform optimisations on that
basis, which might cause bugs here.

Having said that, Inputtools.c is scary as it is prone to buffer overflows: the
size of the ret-buffer is not passed along, and could thus be smaller than
BUFSIZE.

Best,
Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-science-maintainers/attachments/20160126/dc74b1b0/attachment-0001.sig>