Bug#846239: dh-r: PLease do not insert ', ,' sequence in d/control

[Andreas Tille]

Package: dh-r
Severity: normal
Tags: patch

Hi Gordon,

in case of an empty $rdepends string dh-make-R injects ', ,' into
Build-Depends which is a syntax error in d/control.  This patch

diff --git a/scripts/dh-make-R b/scripts/dh-make-R
index dbd0419..4908e53 100755
--- a/scripts/dh-make-R
+++ b/scripts/dh-make-R
@@ -66,7 +66,12 @@ my $rdepends = deps_concat(Debian::Debhelper::Buildsystem::R::parse_depends("Dep
 my $rrecommends = deps_concat(Debian::Debhelper::Buildsystem::R::parse_depends("Recommends", $desc->{Recommends}, \%apthash));
 my $rsuggests = deps_concat(Debian::Debhelper::Buildsystem::R::parse_depends("Suggests", $desc->{Suggests}, \%apthash));
 my $rimports = deps_concat(Debian::Debhelper::Buildsystem::R::parse_depends("Imports", $desc->{Imports}, \%apthash));
-my $builddeps = deps_concat("debhelper (>= 9)", "dh-r", "r-base-dev", $rdepends, $rimports);
+my $builddeps;
+if ( $rdepends ) {
+    $builddeps = deps_concat("debhelper (>= 9)", "dh-r", "r-base-dev", $rdepends, $rimports);
+} else {
+    $builddeps = deps_concat("debhelper (>= 9)", "dh-r", "r-base-dev", $rimports);
+}
 
 say "I: Package depends: $rdepends";
 say "I: Package imports: $rimports";


fixes it and is just commited to Git.

Kind regards

      Andreas.

-- System Information:
Debian Release: 8.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)