Bug#836384: ignition-transport: breaks with new protobuf3, and link failures

[Gianfranco Costamagna]

Source: ignition-transport
Version: 1.3.0-2
Severity: serious

Hi, the latest protobuf3 broke ignition-transport testsuite and package, lets analyze the issues:
(based on the main on debian/tests
#include <ignition/transport.hh>

int main()
{
// Create a transport node.
ignition::transport::Uuid uuid;
return 0;
}



first issue:
./build 
In file included from /usr/include/ignition/transport1/ignition/transport/NodeShared.hh:40:0,
from /usr/include/ignition/transport1/ignition/transport/Node.hh:41,
from /usr/include/ignition/transport1/ignition/transport.hh:9,
from igntest.c:1:
/usr/include/ignition/transport1/ignition/transport/RepHandler.hh:38:41: fatal error: google/protobuf/stubs/casts.h: No such file or directory
#include <google/protobuf/stubs/casts.h>
^


this file has been deleted in new protobuf I guess
(removing that line from the hh file works a little better)

that said, the second issue is:
pkg-config --cflags --libs ignition-transport1
-std=c++11 -I/usr/include/ignition/transport1 -lignition-transport1 -l1


that -l1 breaks the build, lets see:
./build 
/usr/bin/ld: cannot find -l1



g++ -o igntest igntest.c `pkg-config --cflags --libs ignition-transport1`
/usr/bin/ld: cannot find -l1
collect2: error: ld returned 1 exit status



removing it works:
g++ -o igntest igntest.c -std=c++11 -I/usr/include/ignition/transport1 -lignition-transport1
./igntest
echo $?


As usual, please let me know if you have a fix or you need further details

thanks,
G.