Bug#835427: s/XML_NO_ERROR/XML_SUCCESS/

[Peter Green]

On 29/08/16 15:45, Peter Michael Green wrote:
> tags 835427 +patch
> thanks
>> Older versions of tinyxml defined both XML_NO_ERROR and XML_SUCCESS 
>> to 0. Never
>> versions define only XML_SUCCESS.
>
> Attatched is a patch that replaces XML_NO_ERROR with XML_SUCCESS
Unfortunately while that patch fixed the FTBFS in raspbian stretch at 
the time the package is now failing for us for a different reason. While 
I saw this in raspbian I have no reason to belive it is raspbian specific.


In file included from /usr/include/spnav.h:33:0,
                  from /<<BUILDDIR>>/gazebo-7.3.0+dfsg/gazebo/gui/SpaceNav.cc:27:
/usr/include/google/protobuf/stubs/logging.h:66:7: error: expected identifier before 'int'
  class Status;
        ^
/usr/include/google/protobuf/stubs/logging.h:66:7: error: multiple types in one declaration
In file included from /usr/include/google/protobuf/stubs/common.h:45:0,
                  from /usr/include/google/protobuf/stubs/atomicops.h:59,
                  from /usr/include/google/protobuf/stubs/atomic_sequence_num.h:33,
                  from /usr/include/google/protobuf/arena.h:52,
                  from /usr/include/google/protobuf/message.h:118,
                  from /<<BUILDDIR>>/gazebo-7.3.0+dfsg/gazebo/transport/CallbackHelper.hh:20,
                  from /<<BUILDDIR>>/gazebo-7.3.0+dfsg/obj-arm-linux-gnueabihf/gazebo/transport/transport.hh:2,
                  from /<<BUILDDIR>>/gazebo-7.3.0+dfsg/gazebo/gui/SpaceNavPrivate.hh:23,
                  from /<<BUILDDIR>>/gazebo-7.3.0+dfsg/gazebo/gui/SpaceNav.cc:31:
/usr/include/google/protobuf/stubs/logging.h:90:32: error: expected ')' before '::' token
    LogMessage&  operator<<(const ::google::protobuf::util::Status&  status);
                                 ^~
/usr/include/google/protobuf/stubs/logging.h:90:32: error: 'google::protobuf::internal::LogMessage&  google::protobuf::internal::LogMessage::operator<<(...)' must not have variable number of arguments
/usr/include/google/protobuf/stubs/logging.h:90:26: error: expected ';' at end of member declaration
    LogMessage&  operator<<(const ::google::protobuf::util::Status&  status);
                           ^~~~~
In file included from /usr/include/spnav.h:33:0,
                  from /<<BUILDDIR>>/gazebo-7.3.0+dfsg/gazebo/gui/SpaceNav.cc:27:
/usr/include/google/protobuf/stubs/logging.h:90:58: error: expected unqualified-id before 'int'
    LogMessage&  operator<<(const ::google::protobuf::util::Status&  status);
                                                           ^
gazebo/gui/CMakeFiles/gazebo_gui.dir/build.make:1194: recipe for target 'gazebo/gui/CMakeFiles/gazebo_gui.dir/SpaceNav.cc.o' failed

http://buildd.raspbian.org/status/fetch.php?pkg=gazebo&arch=armhf&ver=7.3.0%2Bdfsg-2%2Brpi1%2Bb1&stamp=1472782288

I'm guessing some sort of header conflict, I will try to take a look but not promising anything. Ideas welcome.