Bug#836452: givaro: FTBFS when built with dpkg-buildpackage -A (chmod: cannot access '[...]/isgenerator.C': No such file or directory)

[Santiago Vila]

Package: src:givaro
Version: 4.0.2-2
Severity: serious
Tags: patch

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
(which is what the "Arch: all" autobuilder would do to build it)
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --with autoreconf 
   dh_testdir -i
   dh_update_autotools_config -i
   dh_autoreconf -i
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'macros'.
libtoolize: copying file 'macros/libtool.m4'
libtoolize: copying file 'macros/ltoptions.m4'
libtoolize: copying file 'macros/ltsugar.m4'
libtoolize: copying file 'macros/ltversion.m4'
libtoolize: copying file 'macros/lt~obsolete.m4'

[... snipped ...]

make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/<<PKGBUILDDIR>>/examples/RecInt'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/examples/RecInt'
make[3]: Entering directory '/<<PKGBUILDDIR>>/examples'
make[4]: Entering directory '/<<PKGBUILDDIR>>/examples'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/<<PKGBUILDDIR>>/examples'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/examples'
make[2]: Leaving directory '/<<PKGBUILDDIR>>/examples'
Making install in benchmarks
make[2]: Entering directory '/<<PKGBUILDDIR>>/benchmarks'
make[3]: Entering directory '/<<PKGBUILDDIR>>/benchmarks'
make[4]: Entering directory '/<<PKGBUILDDIR>>/benchmarks'
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/<<PKGBUILDDIR>>/benchmarks'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/benchmarks'
make[2]: Leaving directory '/<<PKGBUILDDIR>>/benchmarks'
make[2]: Entering directory '/<<PKGBUILDDIR>>'
make[3]: Entering directory '/<<PKGBUILDDIR>>'
 /bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tmp/usr/bin'
 /usr/bin/install -c givaro-config givaro-makefile '/<<PKGBUILDDIR>>/debian/tmp/usr/bin'
 /bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tmp/usr/include'
 /usr/bin/install -c -m 644 givaro-config.h '/<<PKGBUILDDIR>>/debian/tmp/usr/include'
 /bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
 /usr/bin/install -c -m 644 givaro.pc '/<<PKGBUILDDIR>>/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_install -i
   dh_installdocs -i
   dh_installchangelogs -i
   debian/rules override_dh_installexamples
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_installexamples -XMakefile -XMakefile.am -XMakefile.in
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_lintian -i
   dh_perl -i
   dh_link -i
   dh_strip_nondeterminism -i
   dh_compress -i
   debian/rules override_dh_fixperms
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_fixperms
chmod -x debian/libgivaro-dev/usr/share/doc/libgivaro-dev/examples/Polynomial/isgenerator.C
chmod: cannot access 'debian/libgivaro-dev/usr/share/doc/libgivaro-dev/examples/Polynomial/isgenerator.C': No such file or directory
debian/rules:35: recipe for target 'override_dh_fixperms' failed
make[1]: *** [override_dh_fixperms] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
debian/rules:41: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
--------------------------------------------------------------------------------

This happens because debian/libgivaro-dev/[...] does not exist,
as we are creating arch-independent packages only and libgivaro-dev
is "Arch: any".

The patch below (trivial but untested) might fix this.

Thanks.

--- a/debian/rules
+++ b/debian/rules
@@ -31,7 +31,7 @@ override_dh_auto_build-indep:
 override_dh_auto_test:
 	dh_auto_test --max-parallel=1
 
-override_dh_fixperms:
+override_dh_fixperms-arch:
 	dh_fixperms
 	chmod -x debian/libgivaro-dev/usr/share/doc/libgivaro-dev/examples/Polynomial/isgenerator.C