Bug#836677: FTBFS: superlu not needed for superlu 5.2

[Drew Parsons]

retitle 836677 FTBFS: superlu patch needs updating for superlu 5.2
thanks

On Sun, 04 Sep 2016 23:59:19 +0800 Drew Parsons <dparsons at debian.org>
wrote:
> 
> pysparse FTBFS against libsuperlu-dev 5.2, with the error:
> 
>   In file included from Src/superlu3module.c:12:0:
>   /usr/include/superlu/slu_ddefs.h:151:16: note: expected ‘SuperLUStat_t * {aka struct <anonymous> *}’ but argument is of type ‘int *’
>    extern void    dgstrf (superlu_options_t*, SuperMatrix*,
>                   ^~~~~~
>   Src/superlu3module.c:270:3: error: too few arguments to function ‘dgstrf’
>      dgstrf(&self->options, &AC, relax, panel_size,
>      ^~~~~~
> 
... 
> I don't know what's going on between superlu 4.3 and 5.2 with respect
> to dgstrf, but if superlu-4.3.patch is not applied, then the build
> of pysparse against superlu 5.2 does complete successfully.
> 

The clue is the warning that precedes the error: "expected
‘SuperLUStat_t *’ but argument is of type ‘int *’

In /usr/include/superlu/slu_ddefs.h for superlu 5.2, a new
SuperLUStat_t* argument for dgstrf is inserted at the end just before
the final int* argument.

So even though the right number of arguments is present when the
superlu patch is deactivated, they're not the right arguments.  Almost
certainly any application using pysparse built without a patch for
superlu 5.2 would crash at runtime.