Bug#836384: closed by Jose Luis Rivero <jrivero at osrfoundation.org> (Bug#836384: fixed in ignition-transport 1.3.0-3)

Fri Sep 9 06:21:05 UTC 2016

control: reopen -1

Hi, can you please also make sure the testsuite works?

there is still the header file wrong include, I suspect nothing using this software can build in this way

autopkgtest [16:52:26]: test build: [-----------------------
Package ignition-msgs0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `ignition-msgs0.pc'
to the PKG_CONFIG_PATH environment variable
Package 'ignition-msgs0', required by 'ignition-transport1', not found
igntest.c:1:33: fatal error: ignition/transport.hh: No such file or directory
#include <ignition/transport.hh>
^
compilation terminated.
autopkgtest [16:52:27]: test build: -----------------------]
autopkgtest [16:52:27]: test build:  - - - - - - - - - - results - - - - - - - - - -
build                FAIL non-zero exit status 1
autopkgtest [16:52:27]: test build:  - - - - - - - - - - stderr - - - - - - - - - -
Package ignition-msgs0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `ignition-msgs0.pc'
to the PKG_CONFIG_PATH environment variable
Package 'ignition-msgs0', required by 'ignition-transport1', not found
igntest.c:1:33: fatal error: ignition/transport.hh: No such file or directory
#include <ignition/transport.hh>
^
compilation terminated.
autopkgtest [16:52:27]: @@@@@@@@@@@@@@@@@@@@ summary
build                FAIL non-zero exit status 1
Exit request sent.

This bad header is installed with ignition-transport

thanks,

G.

Il Giovedì 8 Settembre 2016 3:21, Debian Bug Tracking System <owner at bugs.debian.org> ha scritto:
This is an automatic notification regarding your Bug report
which was filed against the src:ignition-transport package:

#836384: ignition-transport: breaks with new protobuf3, and link failures

It has been closed by Jose Luis Rivero <jrivero at osrfoundation.org>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Jose Luis Rivero <jrivero at osrfoundation.org> by
replying to this email.

-- 
836384: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836384
Debian Bug Tracking System
Contact owner at bugs.debian.org with problemsSource: ignition-transport
Source-Version: 1.3.0-3

We believe that the bug you reported is fixed in the latest version of
ignition-transport, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 836384 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jose Luis Rivero <jrivero at osrfoundation.org> (supplier of updated ignition-transport package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at ftp-master.debian.org)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 06 Sep 2016 21:22:27 +0000
Source: ignition-transport
Binary: libignition-transport1 libignition-transport-dev
Architecture: source
Version: 1.3.0-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers <debian-science-maintainers at lists.alioth.debian.org>
Changed-By: Jose Luis Rivero <jrivero at osrfoundation.org>
Description:
libignition-transport-dev - Ignition Robotics transport Library - Development files
libignition-transport1 - Ignition Robotics Transport Library - Shared library
Closes: 836384
Changes:
ignition-transport (1.3.0-3) unstable; urgency=medium
.
   * Added patch for pkgconfig file
    (Closes: #836384)
Checksums-Sha1:
ad51c8c4fc5fc314d58235cd970dcd9ba6b3e312 2026 ignition-transport_1.3.0-3.dsc
e6aa6bf38cffde7ecd9a13ee0b115cb0131a7c0a 5856 ignition-transport_1.3.0-3.debian.tar.xz
Checksums-Sha256:
c26a5af1431dde2267eee8439126e88186fd5611727119e3f31aae1557409d1d 2026 ignition-transport_1.3.0-3.dsc
f04675d9322581875d1643d40b010ab8821825ceb76718dde8f93831437e2fed 5856 ignition-transport_1.3.0-3.debian.tar.xz
Files:
c82545c34494bf902c881fe5fdc5cccf 2026 science extra ignition-transport_1.3.0-3.dsc
41614dc88887aee170587c927d4fa6e9 5856 science extra ignition-transport_1.3.0-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCgAGBQJX0LdpAAoJEF6UbAkK/wQnJEEIAJ/JPQitgAjVvmV121ei86JJ
ZMBoafAM1FTnKaXOhyc/Jqe7OnhIalvqTnsaNpLOAJ94nn/aHWQuPRS9Do5pcTwG
d+ftbw6zR7uQxB3gE3c2PUhjaUjN3LEPFhs8ZrdNrtVXSIhm9PGVzlI/RJ3zVeWA
Mo27xkuK5awm6HBtoMvy/yDeL545cqKZnkGrFmH4ZvaOmw/dqU1IE+QGhneEVGj4
L07nSEaJh6ntdAO8kcLiJRBRcOfz85PZYMKjHYEF9xSuZOllQpB5QDnft37l+wj+
uHTGVCJqtkrCIvveDTN8Yfk9kqyg8hP5tGpea09P2gseN7K2HenFL18wnB/1Hh4=
=R2T8
-----END PGP SIGNATURE-----
Source: ignition-transport
Version: 1.3.0-2
Severity: serious

Hi, the latest protobuf3 broke ignition-transport testsuite and package, lets analyze the issues:
(based on the main on debian/tests
#include <ignition/transport.hh>

int main()
{
// Create a transport node.
ignition::transport::Uuid uuid;
return 0;
}

first issue:
./build 
In file included from /usr/include/ignition/transport1/ignition/transport/NodeShared.hh:40:0,
from /usr/include/ignition/transport1/ignition/transport/Node.hh:41,
from /usr/include/ignition/transport1/ignition/transport.hh:9,
from igntest.c:1:
/usr/include/ignition/transport1/ignition/transport/RepHandler.hh:38:41: fatal error: google/protobuf/stubs/casts.h: No such file or directory
#include <google/protobuf/stubs/casts.h>
^

this file has been deleted in new protobuf I guess
(removing that line from the hh file works a little better)

that said, the second issue is:
pkg-config --cflags --libs ignition-transport1
-std=c++11 -I/usr/include/ignition/transport1 -lignition-transport1 -l1

that -l1 breaks the build, lets see:
./build 
/usr/bin/ld: cannot find -l1

g++ -o igntest igntest.c `pkg-config --cflags --libs ignition-transport1`
/usr/bin/ld: cannot find -l1
collect2: error: ld returned 1 exit status

removing it works:
g++ -o igntest igntest.c -std=c++11 -I/usr/include/ignition/transport1 -lignition-transport1
./igntest
echo $?

As usual, please let me know if you have a fix or you need further details

thanks,
G.