Bug#837012: tachyon: FTBFS: ld: tachyon_ogl-glwin.o: undefined reference to symbol 'XNextEvent'

[Jerome BENOIT]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi, thanks for your patch.

In fact the issue was not in the Makefile.am as a X_LIBS was already present,
but in the configure.ac where X_LIBS was set up but not SUBSTantiated.

Is there a way to cancel the dealy, given that the revison -6 was accepted.

Thanks,
Jerome

On 13/09/16 06:27, Alastair McKinstry wrote:
> Hi,
> 
> I've uploaded an NMU of tachyon that fixes this to DELAYED/5.
> 
> The debdiff is:
> 
> dpkg-source: warning: extracting unsigned source package (/srv/build/tachyon/tachyon_0.99~b6+dsx-5.1.dsc)
> diff -Nru tachyon-0.99~b6+dsx/debian/changelog tachyon-0.99~b6+dsx/debian/changelog
> --- tachyon-0.99~b6+dsx/debian/changelog    2016-08-01 02:23:29.000000000 +0100
> +++ tachyon-0.99~b6+dsx/debian/changelog    2016-09-12 14:12:26.000000000 +0100
> @@ -1,3 +1,10 @@
> +tachyon (0.99~b6+dsx-5.1) unstable; urgency=medium
> +
> +  * Non-maintainer upload.
> +  * Fix FTBFS: Needs to link against libX11 explicitly. Closes: #837012.
> +
> + -- Alastair McKinstry <mckinstry at debian.org>  Mon, 12 Sep 2016 14:12:26 +0100
> +
>  tachyon (0.99~b6+dsx-5) unstable; urgency=medium
> 
>    * Debianization:
> diff -Nru tachyon-0.99~b6+dsx/debian/patches/series tachyon-0.99~b6+dsx/debian/patches/series
> --- tachyon-0.99~b6+dsx/debian/patches/series    2016-08-01 02:12:39.000000000 +0100
> +++ tachyon-0.99~b6+dsx/debian/patches/series    2016-09-12 14:12:26.000000000 +0100
> @@ -10,3 +10,4 @@
>  upstream-rationalization-autotools.patch
>  debianization.patch
>  debianization-documentation.patch
> +x11.patch
> diff -Nru tachyon-0.99~b6+dsx/debian/patches/x11.patch tachyon-0.99~b6+dsx/debian/patches/x11.patch
> --- tachyon-0.99~b6+dsx/debian/patches/x11.patch    1970-01-01 01:00:00.000000000 +0100
> +++ tachyon-0.99~b6+dsx/debian/patches/x11.patch    2016-09-12 14:12:26.000000000 +0100
> @@ -0,0 +1,19 @@
> +Author: Alastair McKinstry <mckinstry at debian.org>
> +Description: X11 lib is needed for linking
> +Bug-Debian: https://bugs.debian.org/837012
> +Last-Update: 2016-09-12
> +Forwarded: no
> +
> +Index: tachyon-0.99~b6+dsx/demosrc/Makefile.am
> +===================================================================
> +--- tachyon-0.99~b6+dsx.orig/demosrc/Makefile.am
> ++++ tachyon-0.99~b6+dsx/demosrc/Makefile.am
> +@@ -5,7 +5,7 @@ bin_PROGRAMS += tachyon-nox tachyon-ogl
> + man_MANS += tachyon-nox.1 tachyon-ogl.1
> + endif
> +
> +-
> ++X_LIBS= -lX11
> + AM_CFLAGS = -Wno-unused-result
> +
> + tachyon_SOURCES = \
> 
> regards
> Alastair
> 
> 
> On 13/09/2016 01:50, Jerome BENOIT wrote:
>> Hello Lucas, thanks for the report.
>>
>>
>>
>> On 07/09/16 23:18, Lucas Nussbaum wrote:
>> > Source: tachyon
>> > Version: 0.99~b6+dsx-5
>> > Severity: serious
>> > Tags: stretch sid
>> > User: debian-qa at lists.debian.org
>> > Usertags: qa-ftbfs-20160906 qa-ftbfs
>> > Justification: FTBFS on amd64
>>
>> > Hi,
>>
>> > During a rebuild of all packages in sid, your package failed to build on
>> > amd64.
>>
>> > Relevant part (hopefully):
>> >> /bin/bash ../libtool  --tag=CC   --mode=link gcc -Wno-unused-result -I/usr/include/libdrm -I/usr/include/libdrm -g -O3 -fdebug-prefix-map=/<<BUILDDIR>>/tachyon-0.99~b6+dsx=. -fPIE -fstack-protector-strong -Wformat -Werror=format-security -D_REENTRANT -ffast-math -fomit-frame-pointer   -o tachyon-ogl tachyon_ogl-main.o tachyon_ogl-getargs.o tachyon_ogl-parse.o tachyon_ogl-nffparse.o tachyon_ogl-mgfparse.o tachyon_ogl-ac3dparse.o tachyon_ogl-glwin.o tachyon_ogl-spaceball.o tachyon_ogl-trackball.o ../src/libtachyon.la -lm -lGL  -lGL
>> >> libtool: link: gcc -Wno-unused-result -I/usr/include/libdrm -I/usr/include/libdrm -g -O3 "-fdebug-prefix-map=/<<BUILDDIR>>/tachyon-0.99~b6+dsx=." -fPIE -fstack-protector-strong -Wformat -Werror=format-security -D_REENTRANT -ffast-math -fomit-frame-pointer -o .libs/tachyon-ogl tachyon_ogl-main.o tachyon_ogl-getargs.o tachyon_ogl-parse.o tachyon_ogl-nffparse.o tachyon_ogl-mgfparse.o tachyon_ogl-ac3dparse.o tachyon_ogl-glwin.o tachyon_ogl-spaceball.o tachyon_ogl-trackball.o  ../src/.libs/libtachyon.so -lm -lGL
>> >> /usr/bin/ld: tachyon_ogl-glwin.o: undefined reference to symbol 'XNextEvent'
>> >> //usr/lib/x86_64-linux-gnu/libX11.so.6: error adding symbols: DSO missing from command line
>> >> collect2: error: ld returned 1 exit status
>>
>> > The full build log is available from:
>> >    http://people.debian.org/~lucas/logs/2016/09/06/tachyon_0.99~b6+dsx-5_unstable.log
>>
>> I could reproduce the issue in a chroot environment.
>> I am working on it.
>>
>>
>>
>> > A list of current common problems and possible solutions is available at
>> > http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
>>
>> > About the archive rebuild: The rebuild was done on EC2 VM instances from
>> > Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
>> > failed build was retried once to eliminate random failures.
>>
>>
>> Thanks,
>> Jerome
>>
>>
> 
> -- 
> Alastair McKinstry, <alastair at sceal.ie>, <mckinstry at debian.org>, https://diaspora.sceal.ie/u/amckinstry
> Misentropy: doubting that the Universe is becoming more disordered.
> 

- -- 
Jerome BENOIT | calculus+at-rezozer^dot*net
https://qa.debian.org/developer.php?login=calculus@rezozer.net
AE28 AE15 710D FF1D 87E5  A762 3F92 19A6 7F36 C68B
-----BEGIN PGP SIGNATURE-----

iQQcBAEBCgAGBQJX19CdAAoJED+SGaZ/NsaL/YUgAMyiu6Scw0cOzDWVTki+TbKK
iTWQvK1nzrZhOgYm91NCli6mUjI4+uFrA6WOjpw9UNkUsnJtnhyOWXMI8u/inrFV
1yQEtKUIwYw2Y+fczpCPBUttUx2JZdA0A8mSqqCSxF3B1rTD2qeVfpyTU+cFF+CS
jpM3TIg4B9R7ioA7oDxo42xRZY019Q7JUE8Lr58JdrGmn4DWpSyz1AMn5Kq7kVw7
jZD2tHUDs+1xHUXXRoFDJneCzL4DQ8HLM0cYcj6fhLlCFtkKfIL/F8ifUApYm9C5
qGY7uGgmIfiHGDRa41V5g4Rne2JT6HWT5k+xz1a5OlwYJgTdbK2jcVfdFY0Ef+lI
skb+uzxOrZ/Ih07R78bbAgSbgH2N2YAb11tsQwYDFghM7r+DlKLCU0bF5OUxTSh1
4iCXW8Ri8iRtCWuA1iB0cUpf9zS8wVwGwxhS0ItLQVNvKIJHb+TJhvqwQMxISFTA
mQ/nHpxnDM+3DnEvxmiqdacZT3X0qLDD33fZv3XWuutVm4PGB79eV+hbJ9ofEHiA
MRsJs69HlSzHm40132YrNpY4NAQ1sGYFzaomgvif4Ykoka2JBENpqTnc+kXzG0BF
6Hmyra5Gu8qX8jg4zECY9fZhKCvHDT/hxY6GCskGU/Mg8nProldWJ//yyDRzV9dY
l1P/jIkVP/CcS128ouTNIpXDRz0rolU5xejvlxqOEjTRj51nJvcLRq4WPfWEEpfN
n8AUdqodDY+wpvnXWxtomr40Rpn4tVzvtovdpWnQomoOSiMhaXNk6Othd1O7u2/y
HhtrZJ2Ye4n1oPVfumDLUH7rQXEpEArsHxY085En9o4X/ZYtHiL0kvsLlLkRXkIA
5gTHglGiiIqLGL70BFUaYJ/1Zgmzpwz3pn2djCgGldUGQd5R5cZMFqfWy3EPG50R
65TyMCertOnyOZwpvkokEQxC+dlOsEqUPyHabXh5YUUqp65WHjZ4TkEQZhD/Gsq2
vVWL5clzZsvNhq6mdg1MjiikCGhLI3SWJ6A48UHv7ZQ7+WNa8pT1SkM3ZHeEvnIh
MzS7Bl9hFB876BwHWmkd3TtHTf+yjQCuVvT8CQeW+KBQxpWvvWx++RpiNmwG5n5t
iuidaZ+XyS6HZErb00uArUIB31LmDrxF2KbjB6eyRZKo2Pl5c4mmlmxR+GXu70qZ
LnEmk75zFOekYWNDok4Z8IrDOOiOXNa7dGXHE4nJHXMc4pM4raKuRk6b0r5kahrQ
upvvgNvj7eCgbPMfR/0rWQfZBqvEhOWccjSjvPZGK3QlWCrETx61c+DKxj/tQsDn
s445NFH/bMzjhhR26WQSfs2vXSd0VFMYqD7qXNs+vY1yMlFGgU4k/gFP+9iiXzU=
=YjGQ
-----END PGP SIGNATURE-----