Bug#870128: libgpuarray: broken autopkgtests

[Ghislain Vaillant]

On Sat, 29 Jul 2017 23:33:21 -0700 Steve Langasek
<steve.langasek at canonical.com> wrote:
>
> Your latest upload of libgpuarray has replaced the previous python
> autopkgtest with one based on pocl.

Indeed, which allows running the upstream test suite on our CPU-based
builders. This is better than the default autopkgtest-pkg-python, which
does nothing but testing the import of the Python module.

> Unfortunately, this means that the autopkgtests now consistently fail
> on ci.debian.net, because they can no longer be run on a system without
> a gpu, e.g.:

Your assessment is wrong. pocl is a **CPU** implementation of OpenCL,
so the tests should run in principle. The issue is that the test suite
does not skip tests for which a specific compute must be satisfied by
the environment, such as CUDA and float16. The rest of the tests runs
fine.

I filed the following issues upstream as a result:

https://github.com/Theano/libgpuarray/issues/491
https://github.com/Theano/libgpuarray/issues/492

> ======================================================================
> ERROR: pygpu.tests.test_gpu_ndarray.test_asfortranarray((),
'float32', True, True, 1, 'f')
> -------------------------------------------------------------------
---
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in
runTest
>     self.test(*self.arg)
>   File "/usr/lib/python2.7/dist-packages/pygpu/tests/support.py",
line 44, in f
>     func(*args, **kwargs)
>   File "/usr/lib/python2.7/dist-
packages/pygpu/tests/test_gpu_ndarray.py", line 196, in asfortranarray
>     assert b.gpudata == gpu.gpudata
>   File "pygpu/gpuarray.pyx", line 2260, in
pygpu.gpuarray.GpuArray.gpudata.__get__ (pygpu/gpuarray.c:28840)
> TypeError: This is for CUDA arrays.
> 
> https://ci.debian.net/packages/libg/libgpuarray/unstable/amd64/
> 
> I would suggest that it's more useful to have a basic autopkgtest
that
> passes on generic hardware than to have a deep autopkgtest which will
never
> succeed there.

The old basic does nothing. For such package, testing whether the
import is successful is hardly testing at all.

> I am filing this bug because failing autopkgtests are considered
blockers
> for inclusion of a package in the Ubuntu release.  Newer versions of
> libgpuarray might not be included in Ubuntu releases until this is
resolved.

I believe this is wrong. How can we provide upstream with meaningful
logs without enabling the tests in the first place? I can keep the old
autopkgtest-pkg-python to satisfy Ubuntu's policy, but what good would
it make?

Ghis