Bug#865652: pcl shouldn't disable PIE

[Adrian Bunk]

Source: pcl
Version: 1.8.0+dfsg1-3
Severity: normal
Tags: patch

With gcc in stretch defaulting to PIE, hardening=+all,-pie changed
semantics from "enable hardening but not PIE" to "enable all hardening
and explicitely disable the default PIE".
The latter is usually not intended.

The -pie in hardening flags was in some cases required in pre-stretch
releases to avoid build failures caused by (incorrectly) passing -fPIE
to the compiler when building shared libraries or plugins.
This problem does no longer exist.

Please consider applying the following patch:

--- debian/rules.old	2017-06-23 06:14:39.000000000 +0000
+++ debian/rules	2017-06-23 06:14:46.000000000 +0000
@@ -1,7 +1,7 @@
 #!/usr/bin/make -f
 
 # Hardening.
-export DEB_BUILD_MAINT_OPTIONS=hardening=+all,-pie
+export DEB_BUILD_MAINT_OPTIONS=hardening=+all
 
 CPPFLAGS:=$(shell dpkg-buildflags --get CPPFLAGS)
 CFLAGS:=$(shell dpkg-buildflags --get CFLAGS)