Bug#865739: ros-image-common shouldn't disable PIE

[Adrian Bunk]

Source: ros-image-common
Version: 1.11.11-2
Severity: normal
Tags: patch

With gcc in stretch defaulting to PIE, hardening=+all,-pie changed
semantics from "enable hardening but not PIE" to "enable all hardening
and explicitely disable the default PIE".
The latter is usually not intended.

The -pie in hardening flags was in some cases required in pre-stretch
releases to avoid build failures caused by (incorrectly) passing -fPIE
to the compiler when building shared libraries or plugins.
This problem does no longer exist.

Please consider applying the following patch:

--- debian/rules.old	2017-06-24 11:36:17.000000000 +0000
+++ debian/rules	2017-06-24 11:36:25.000000000 +0000
@@ -1,5 +1,6 @@
 #!/usr/bin/make -f
-export DEB_BUILD_MAINT_OPTIONS = hardening=+all,-pie
+
+export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 
 %:
 	dh $@ --parallel --with=python2 --buildsystem=cmake