Bug#906921: tango-starter does not start after a reboot

[Carlos Manuel Falcon Torres]

Package: tango-starter
Version: 9.2.5a+dfsg1-2
Severity: normal

Dear Maintainer,

We saw that in some machines the tango-starter did not start after 
rebooting the PC.

Note: We are using a custom version of the tango package  ( 
9.2.5a+dfsg1-2+patch1~bpo9+0~alba+1)

which has a patch that only affects the libtango9 package and for the 
purposes of this bug report is equivalent to 9.2.5a+dfsg1-2

systemctl status tango-starter reports:

tango-starter.service - LSB: Start the tango control system starter daemon
    Loaded: loaded (/etc/init.d/tango-starter; generated; vendor preset: 
enabled)
    Active: active (exited) since Wed 2018-08-22 11:59:22 CEST; 2min 24s ago
      Docs: man:systemd-sysv-generator(8)
   Process: 563 ExecStart=/etc/init.d/tango-starter start (code=exited, 
status=0/SUCCESS)
     Tasks: 0 (limit: 4915)
    CGroup: /system.slice/tango-starter.service


Our version follows the official package plus a patch to remove an 
internal sleep in the code of Tango
(it does not affect to the tango-starter package)

The service works as expected if you "restart" it once the pc is running 
(systemctl start tango-starter).
  Adding traces we figured out that the problem is a race condition 
since we are using the network;
So, tango_admin --ping-network 40 and the tango_admin --ping-network 40 
check fails

We solved the trouble adding to Should-Start/Stop option the network ;

# Should-Start:      tango-db network
# Should-Stop:       tango-db network

Could you add this fix in the init script of the official package? If 
you prefer I can do a PR in salsa.d.o


-- System Information:
Debian Release: 9.4
   APT prefers stable-updates
   APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-6-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE= (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)

Versions of packages tango-starter depends on:
ii  libc6             2.24-11+deb9u3
ii  libcos4-1         4.1.6-2.1+b1
ii  libgcc1           1:6.3.0-18+deb9u1
ii  liblog4tango5v5   9.2.5a+dfsg1-2+patch1~bpo9+0~alba+1
ii  libomniorb4-1     4.1.6-2.1+b1
ii  libomnithread3c2  4.1.6-2.1+b1
ii  libstdc++6        6.3.0-18+deb9u1
ii  libtango-tools    9.2.5a+dfsg1-2+patch1~bpo9+0~alba+1
ii  libtango9         9.2.5a+dfsg1-2+patch1~bpo9+0~alba+1
ii  libzmq5           4.2.1-4
ii  lsb-base          9.20161125

tango-starter recommends no packages.

Versions of packages tango-starter suggests:
pn  omninotify  <none>

-- no debconf information