Bug#915514: pysph: Missing build-dependency on python-pytest-runner, Debian builds pulling source from network?

[Steve Langasek]

Package: pysph
Version: 0~20180411.git1ae58e1-2
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu disco ubuntu-patch

Dear maintainers,

The pysph package was failing to build in Ubuntu because it is trying to hit
pypi.org at build time, and this is (intentionally) denied by the firewall
in Launchpad:

[...]
[16/16] Cythonizing pyzoltan/core/carray.pyx
Download error on https://pypi.org/simple/pytest-runner/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'pytest-runner' (maybe misspelled?)
Download error on https://pypi.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for pytest-runner
Traceback (most recent call last):
  File "setup.py", line 751, in <module>
    setup_package()
  File "setup.py", line 746, in setup_package
    """.splitlines() if len(c.split()) > 0],
  File "/usr/lib/python2.7/dist-packages/setuptools/__init__.py", line 139, in setup
    _install_setup_requires(attrs)
  File "/usr/lib/python2.7/dist-packages/setuptools/__init__.py", line 134, in _install_setup_requires
    dist.fetch_build_eggs(dist.setup_requires)
  File "/usr/lib/python2.7/dist-packages/setuptools/dist.py", line 514, in fetch_build_eggs
    replace_conflicting=True,
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 777, in resolve
    replace_conflicting=replace_conflicting
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 1060, in best_match
    return self.obtain(req, installer)
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 1072, in obtain
    return installer(requirement)
  File "/usr/lib/python2.7/dist-packages/setuptools/dist.py", line 581, in fetch_build_egg
    return cmd.easy_install(req)
  File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 695, in easy_install
    raise DistutilsError(msg)
distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pytest-runner')
make[1]: *** [Makefile:22: build] Error 1
[...]

   (https://launchpad.net/ubuntu/+source/pysph/0~20180411.git1ae58e1-2)

Since this is listed as a requirement in setup.py, and is not pulled in as a
build dependency in Debian, I suspect the Debian builds have succeeded only
because the network is *not* filtered on the Debian builders.  In that case,
pysph's source package is not self-hosting, which is not a good thing.

I've uploaded the attached patch to Ubuntu, which fixes the build failure. 
Please consider applying it in Debian as well.

If you're able to confirm that the build failure applies to Debian also, you
might want to raise the severity of the bug report.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru pysph-0~20180411.git1ae58e1/debian/control pysph-0~20180411.git1ae58e1/debian/control
--- pysph-0~20180411.git1ae58e1/debian/control	2018-05-20 08:43:05.000000000 -0700
+++ pysph-0~20180411.git1ae58e1/debian/control	2018-12-04 02:28:20.000000000 -0800
@@ -11,6 +11,8 @@
                python-mock,
                python-nose,
                python-numpy,
+               python-pytest,
+               python-pytest-runner,
                python-sphinx,
                python-sphinx-rtd-theme,
                python-traits,