Bug#915148: [Pkg-cmake-team] Bug#915148: cmake: regression in ros-ros-comm build

[Jochen Sprickerhof]

Hi Gianfranco,

* Gianfranco Costamagna <locutusofborg at debian.org> [2018-12-05 10:36]:
>
>
>>catkin upstream would prefer to add -pthread instead of -lpthread to the
>>compiler flags. See the discussion here:
>>
>>https://github.com/ros/catkin/issues/856
>>
>>Would this be possible?
>
>what about:
>|   elseif(${library} MATCHES "^-l")  |
>|
>
>  list(APPEND @PROJECT_NAME at _LIBRARIES ${library})
>|   elseif(${library} MATCHES "^-p")  |
>|
>
>  list(APPEND @PROJECT_NAME at _LIBRARIES ${library})

I think you got me wrong, the current workaround works already.

>BTW, -lpthread is generally wrong, and useful only to fix underlinking.The right thing to do is to add "-pthread" to CFLAGS, not to LDFLAGS

This is what I was asking for and should be fixed in cmake. So I would 
propose to reopen this and assign to cmake, do you agree?

Cheers Jochen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/debian-science-maintainers/attachments/20181205/a0c13153/attachment.sig>