Segyio 1.8.0 new upstream release

[Jørgen Kvalsvik]

It seems to me that it's a race condition in the test suite, then. I can fix it with an upstream release and version number bump, or a new packaging which either forces seralisation or applies said patch. Which one would you prefer?

________________________________________
From: Sébastien Villemot <sebastien at debian.org>
Sent: Wednesday, December 19, 2018 11:49:34 AM
To: Jørgen Kvalsvik; debian-science-maintainers at lists.alioth.debian.org
Subject: Re: Segyio 1.8.0 new upstream release

Le mardi 18 décembre 2018 à 11:27 +0000, Jørgen Kvalsvik a écrit :

> Are these tests run in parallel, by any chance?

I build with the default options, which means that debhelper is invoked
 with parallelism activated. Whether this translates into several tests
being run in parallel, I don't know, this depends on your build system.

However, the error does not appear at every build, so indeed it is very
likely a race condition.

> If you apply this patch, does the error still persist?

With this patch applied, it seems the error no longer occurs (though
it's always hard to tell due to the non-deterministic nature of the
problem).

Best,

P.S.: please do not top-post.

> ________________________________________
> > From: Sébastien Villemot <sebastien at debian.org>
> Sent: Tuesday, December 18, 2018 12:16:49 PM
> To: Jørgen Kvalsvik; debian-science-maintainers at lists.alioth.debian.org
> Subject: Re: Segyio 1.8.0 new upstream release
>
> Hi Jørgen,
>
> Le lundi 17 décembre 2018 à 16:33 +0000, Jørgen Kvalsvik a écrit :
>
> > I just pushed the new segyio-1.8.0. I'd love an upload so that it
> > hits before Buster is frozen. Addtionally, it fixes Bug#916342 that
> > surfaced a week ago.
>
> I tried to compile the package, but I get a FTBFS (during tests), see
> below.
>
> BTW, in the future, you should rather send your sponsorship requests to
> debian-science at lists.debian.org (to which I am subscribed).
>
>
>
> 26/27 Test  #4: c.segy.mmap.lsb ..................***Failed    0.09 sec
>
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> c.segy is a Catch v2.2.3 host application.
> Run with -? for options
>
> -------------------------------------------------------------------------------
> write ascending strided subtrace
> -------------------------------------------------------------------------------
> /<<PKGBUILDDIR>>/lib/test/segy.cpp:887
> ...............................................................................
>
> /<<PKGBUILDDIR>>/lib/test/testsuite.cpp:25: FAILED:
>   REQUIRE( segy_mmap( fp ) == SEGY_OK )
> with expansion:
>   11 == 0
>
> -------------------------------------------------------------------------------
> write descending strided subtrace with pre-start
> -------------------------------------------------------------------------------
> /<<PKGBUILDDIR>>/lib/test/segy.cpp:931
> ...............................................................................
>
> /<<PKGBUILDDIR>>/lib/test/testsuite.cpp:25: FAILED:
>   REQUIRE( segy_mmap( fp ) == SEGY_OK )
> with expansion:
>   11 == 0
>
> ===============================================================================
> test cases:  80 |  78 passed | 2 failed
> assertions: 477 | 475 passed | 2 failed
>
>
> 27/27 Test  #3: c.segy.lsb .......................***Failed    0.09 sec
>
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> c.segy is a Catch v2.2.3 host application.
> Run with -? for options
>
> -------------------------------------------------------------------------------
> write descending strided subtrace
> -------------------------------------------------------------------------------
> /<<PKGBUILDDIR>>/lib/test/segy.cpp:909
> ...............................................................................
>
> /<<PKGBUILDDIR>>/lib/test/segy.cpp:877: FAILED:
>   CHECK_THAT( trace, ApproxRange( expected ) )
> with expansion:
>   { 0.0f, 0.00005f, 857948416.0f, 3.0f, 0.0f, 0.0f, 0.0f, 0.0f, 8.0f, 0.0f, 0.
>   0f, 0.0f, 0.0f, 13.0f, 0.0f, 0.0f, 0.0f, 0.0f, 18.0f, nanf, 0.0f, 0.0f, 0.0f,
>   0.0f, 0.0f, 0.0f, 834.20337f, 14675460868800512.0f,
>   16135839868217842121742221312.0f, nanf, nanf, nanf, 0.0f, 0.0f, 0.0f, -0.0f,
>   -0.0f, -0.0f, -3.25861f, -57326019018752.0f, -63030624485225945788055552.0f,
>   nanf, nanf, nanf, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f } ~= { 0.0f, 0.0f, 0.0f,
>   3.0f, 0.0f, 0.0f, 0.0f, 0.0f, 8.0f, 0.0f, 0.0f, 0.0f, 0.0f, 13.0f, 0.0f, 0.
>   0f, 0.0f, 0.0f, 18.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f,
>   0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f,
>   0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f }
>
> ===============================================================================
> test cases:  80 |  79 passed | 1 failed
> assertions: 420 | 419 passed | 1 failed
>
>
>
> 93% tests passed, 2 tests failed out of 27

--
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  http://sebastien.villemot.name
⠈⠳⣄⠀⠀⠀⠀  http://www.debian.org


-------------------------------------------------------------------
The information contained in this message may be CONFIDENTIAL and is
intended for the addressee only. Any unauthorized use, dissemination of the
information or copying of this message is prohibited. If you are not the
addressee, please notify the sender immediately by return e-mail and delete
this message.
Thank you