Bug#886361: apertium: frequent parallel FTBFS

[Adrian Bunk]

Source: apertium
Version: 3.4.2~r68466-3
Severity: serious
Tags: patch

https://tests.reproducible-builds.org/debian/history/apertium.html
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/apertium.html
https://buildd.debian.org/status/package.php?p=apertium&suite=sid

...
/bin/bash ../libtool  --tag=CXX   --mode=link g++  -Wall -Wextra -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security  -Wl,-z,relro -Wl,-z,now -o apertium-filter-ambiguity apertium_filter_ambiguity.o -llttoolbox3 -lxml2 -lpcre -lapertium3 -lpcreposix -lpcre -lpcrecpp -llttoolbox3 -lxml2 -lpcre
libtool: link: g++ -Wall -Wextra -g -O2 "-fdebug-prefix-map=/<<PKGBUILDDIR>>=." -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o apertium-filter-ambiguity apertium_filter_ambiguity.o  -lapertium3 -lpcreposix -lpcrecpp -llttoolbox3 -lxml2 -lpcre
/usr/bin/ld: cannot find -lapertium3
collect2: error: ld returned 1 exit status
Makefile:1056: recipe for target 'apertium-filter-ambiguity' failed
make[3]: *** [apertium-filter-ambiguity] Error 1


This was triggered by dh comat >= 10 defaulting to parallel building.

Fix attached.
-------------- next part --------------
Description: Fix parallel FTBFS
 Tell automake that libapertium3 is a self-built library
 so that proper dependencies are added.
Author: Adrian Bunk <bunk at debian.org>

--- apertium-3.4.2~r68466.orig/apertium/Makefile.am
+++ apertium-3.4.2~r68466/apertium/Makefile.am
@@ -226,7 +226,7 @@ apertium_DATA = deformat.xsl reformat.xs
 
 apertium_pretransfer_SOURCES = apertium_pretransfer.cc
 apertium_multiple_translations_SOURCES = apertium-multiple-translations.cc
-apertium_multiple_translations_LDADD = $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+apertium_multiple_translations_LDADD = $(APERTIUM_LIBS) libapertium3.la
 apertium_destxt_SOURCES = apertium_destxt.cc
 apertium_retxt_SOURCES = apertium_retxt.cc
 apertium_deshtml_SOURCES = apertium_deshtml.cc
@@ -249,55 +249,55 @@ apertium_repptx_SOURCES = apertium_reppt
 apertium_desmediawiki_SOURCES = apertium_desmediawiki.cc
 apertium_remediawiki_SOURCES = apertium_remediawiki.cc
 apertium_prelatex_SOURCES = apertium_prelatex.cc
-apertium_prelatex_LDADD= $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+apertium_prelatex_LDADD= $(APERTIUM_LIBS) libapertium3.la
 apertium_postlatex_SOURCES = apertium_postlatex.cc
-apertium_postlatex_LDADD= $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+apertium_postlatex_LDADD= $(APERTIUM_LIBS) libapertium3.la
 apertium_postlatex_raw_SOURCES = apertium_postlatex_raw.cc
-apertium_postlatex_raw_LDADD= $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+apertium_postlatex_raw_LDADD= $(APERTIUM_LIBS) libapertium3.la
 
 apertium_tagger_SOURCES = apertium_tagger.cc
-apertium_tagger_LDADD = $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+apertium_tagger_LDADD = $(APERTIUM_LIBS) libapertium3.la
 
 apertium_tmxbuild_SOURCES = apertium_tmxbuild.cc
-apertium_tmxbuild_LDADD = $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+apertium_tmxbuild_LDADD = $(APERTIUM_LIBS) libapertium3.la
 
 apertium_preprocess_transfer_SOURCES = transferpp.cc
 apertium_preprocess_transfer_LDADD = $(APERTIUM_LIBS) \
-                                     -lapertium$(GENERIC_MAJOR_VERSION)
+                                     libapertium3.la
 
 apertium_filter_ambiguity_SOURCES = apertium_filter_ambiguity.cc
 apertium_filter_ambiguity_LDADD = $(APERTIUM_LIBS) \
-                                  -lapertium$(GENERIC_MAJOR_VERSION)
+                                  libapertium3.la
 
 apertium_transfer_SOURCES = apertium_transfer.cc
-apertium_transfer_LDADD = $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+apertium_transfer_LDADD = $(APERTIUM_LIBS) libapertium3.la
 
 apertium_interchunk_SOURCES = apertium_interchunk.cc
-apertium_interchunk_LDADD = $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+apertium_interchunk_LDADD = $(APERTIUM_LIBS) libapertium3.la
 
 apertium_postchunk_SOURCES = apertium_postchunk.cc
-apertium_postchunk_LDADD = $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+apertium_postchunk_LDADD = $(APERTIUM_LIBS) libapertium3.la
 
 ###apertium_lextor_SOURCES = apertium_lextor.cc
-###apertium_lextor_LDADD = $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+###apertium_lextor_LDADD = $(APERTIUM_LIBS) libapertium3.la
 
 #apertium_lextor_eval_SOURCES = apertium-lextor-eval.C
-#apertium_lextor_eval_LDADD = $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+#apertium_lextor_eval_LDADD = $(APERTIUM_LIBS) libapertium3.la
 
 apertium_tagger_apply_new_rules_SOURCES = apertium_tagger_apply_new_rules.cc
-apertium_tagger_apply_new_rules_LDADD = $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+apertium_tagger_apply_new_rules_LDADD = $(APERTIUM_LIBS) libapertium3.la
 
 apertium_tagger_readwords_SOURCES = apertium_tagger_readwords.cc
-apertium_tagger_readwords_LDADD = $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+apertium_tagger_readwords_LDADD = $(APERTIUM_LIBS) libapertium3.la
 
 ###apertium_lextor_search_SOURCES = apertium-lextor-search.C
-###apertium_lextor_search_LDADD = $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+###apertium_lextor_search_LDADD = $(APERTIUM_LIBS) libapertium3.la
 
 ###pruebas_lextor_SOURCES = pruebas-lextor.C
-###pruebas_lextor_LDADD = $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+###pruebas_lextor_LDADD = $(APERTIUM_LIBS) libapertium3.la
 
 ###apertium_gen_wlist_lextor_translation_SOURCES = apertium_gen_wlist_lextor_translation.cc
-###apertium_gen_wlist_lextor_translation_LDADD = $(APERTIUM_LIBS) -lapertium$(GENERIC_MAJOR_VERSION)
+###apertium_gen_wlist_lextor_translation_LDADD = $(APERTIUM_LIBS) libapertium3.la
 
 
 if WINDOWS