Bug#887918: tkgate uses deprecated Tcl/Tk 8.5

[Sergei Golovan]

Source: tkgate
Version: 2.0~b10-5
Severity: important
Tags: patch

Dear Maintainer,

Since Tcl/Tk 8.5 has reached its end of life we are seeking to remove it from
Debian. So please, switch the tkgate package to 8.6 (or to a currently default
version which is 8.6 anyway).

I'm attaching a proposed NMU which replaces tcl8.5-dev, tk8.5-dev by simply
tcl-dev, tk-dev (the current default version), and adds a definition which
allows the program to build using Tcl/Tk 8.6 (it enables a deprecated struct
field). If you don't mind, I could do this upload for you.

-- System Information:
Debian Release: 9.3
  APT prefers stable-debug
  APT policy: (500, 'stable-debug'), (500, 'proposed-updates'), (500, 'stable'), (1, 'unstable'), (1, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.14.0-0.bpo.3-amd64 (SMP w/12 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
diff -Nru tkgate-2.0~b10/debian/changelog tkgate-2.0~b10/debian/changelog
--- tkgate-2.0~b10/debian/changelog	2016-04-27 13:48:05.000000000 +0300
+++ tkgate-2.0~b10/debian/changelog	2018-01-21 20:05:19.000000000 +0300
@@ -1,3 +1,13 @@
+tkgate (2.0~b10-5.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Switch to the default Tcl/Tk version from Tcl/Tk 8.5 since the latter is
+    to be removed from Debian.
+  * Add -DUSE_INTERP_RESULT to CFLAGS to enable the deprecated result field
+    in the Tcl interp struct.
+
+ -- Sergei Golovan <sgolovan at debian.org>  Sun, 21 Jan 2018 20:05:19 +0300
+
 tkgate (2.0~b10-5) unstable; urgency=medium
 
   * changed the field Homepage: in d/control, as the current version comes from
diff -Nru tkgate-2.0~b10/debian/control tkgate-2.0~b10/debian/control
--- tkgate-2.0~b10/debian/control	2016-04-27 13:18:26.000000000 +0300
+++ tkgate-2.0~b10/debian/control	2018-01-21 20:05:19.000000000 +0300
@@ -4,7 +4,7 @@
 Maintainer:  Debian Science Maintainers <debian-science-maintainers at lists.alioth.debian.org>
 Uploaders: Georges Khaznadar <georgesk at debian.org>
 Standards-Version: 3.9.8
-Build-Depends: debhelper (>=7.0.50~), tcl8.5-dev, tk8.5-dev, bison|byacc, flex,
+Build-Depends: debhelper (>=7.0.50~), tcl-dev, tk-dev, bison|byacc, flex,
  xutils-dev, libx11-dev, quilt (>= 0.46-7~), autotools-dev
 Homepage: http://perso.univ-perp.fr/guillaume.revy/teaching/softs/tkgate.html
 Vcs-Git: git://git.debian.org/git/debian-science/packages/tkgate.git
diff -Nru tkgate-2.0~b10/debian/rules tkgate-2.0~b10/debian/rules
--- tkgate-2.0~b10/debian/rules	2016-04-27 14:50:45.000000000 +0300
+++ tkgate-2.0~b10/debian/rules	2018-01-21 20:05:19.000000000 +0300
@@ -6,7 +6,7 @@
 	dh $@ --with quilt,autotools_dev
 
 CPPFLAGS:=$(shell dpkg-buildflags --get CPPFLAGS)
-CFLAGS:=$(shell dpkg-buildflags --get CFLAGS)
+CFLAGS:=$(shell dpkg-buildflags --get CFLAGS) -DUSE_INTERP_RESULT
 CXXFLAGS:=$(shell dpkg-buildflags --get CXXFLAGS)
 LDFLAGS:=$(shell dpkg-buildflags --get LDFLAGS)