Bug#898847: librosbag-dev: Missing dependency on libstd-srvs-dev

[Johannes Schauer]

Package: librosbag-dev
Version: 1.13.5+ds1-3
Severity: normal

Hi,

/usr/share/rosbag/cmake/rosbagConfig.cmake contains (around line 165):

set(depends "rosbag_storage;rosconsole;roscpp;std_srvs;topic_tools;xmlrpcpp")
foreach(depend ${depends})
      [...]
      find_package(${rosbag_dep} REQUIRED NO_MODULE)

the package already depends on librosbag-storage-dev, librosconsole-dev,
libroscpp-dev, libtopic-tools-dev and libxmlrpcpp-dev but it does *not*
yet depend on libstd-srvs-dev and thus, an error will be raised:

-- catkin 0.7.8
CMake Error at /usr/share/rosbag/cmake/rosbagConfig.cmake:165 (find_package):
  Could not find a package configuration file provided by "std_srvs" with any
  of the following names:

    std_srvsConfig.cmake
    std_srvs-config.cmake

  Add the installation prefix of "std_srvs" to CMAKE_PREFIX_PATH or set
  "std_srvs_DIR" to a directory containing one of the above files.  If
  "std_srvs" provides a separate development package or SDK, be sure it has
  been installed.

You can easily reproduce this with a simple CMakeLists.txt:

cmake_minimum_required(VERSION 3.9)
find_package(catkin REQUIRED COMPONENTS rosbag)

It would probably help to add a very simple autopkgtest to the package
which just tries to configure such a trivial CMake project. You could
get yourself inspired with what I did for orocos-bfl:

https://sources.debian.org/src/orocos-bfl/0.8.0-4/debian/tests/run-tests/

It will be much simpler though in this case. :)

Thanks!

cheers, josch