Bug#890571: libmseed-dev: libmseed.h misses unistd.h on non-Linux

[Paride Legovini]

"Aaron M. Ucko" <ucko at debian.org> wrote on Thu, 15 Feb 2018:
> libmseed.h's #include directive for <unistd.h> is conditional on
> 
>   defined(LMP_LINUX) || defined(LMP_BSD) || defined(LMP_SOLARIS)
> 
> none of which winds up defined on the Hurd (or even kFreeBSD, seeing
> how LMP_BSD is conditionalized).  Any halfway modern __unix system
> (including in particular all Debian architectures) will have this
> header; please #include it more widely.
> 
> As it stands, this conditionalization breaks the build of mseed2sac
> for hurd-i386 [1] (admittedly not a release architecture):
> 
>   mseed2sac.c:543:9: warning: implicit declaration of function 'access'; did you mean 'acosl'? [-Wimplicit-function-declaration]
>   mseed2sac.c:543:26: error: 'F_OK' undeclared (first use in this function)
> 
> Could you please take a look?

Dear Pierre,

A friendly ping on this, just in case it slipped under your radar. I'm
the maintainer of mseed2sac, I'd appreciate if you could fix this. I
think you'll be able to detect GNU/Hurd by looking for __GNU__ and
GNU/kFreeBSD by looking for (__FreeBSD_kernel__ && __GLIBC__).

The file to patch is:

https://github.com/iris-edu/msi/blob/master/libmseed/libmseed.h#L57

and Chad Trabant (Cc:) may be willing to upstream the patch.

See also:

https://sourceforge.net/p/predef/wiki/OperatingSystems/

Thank you,

Paride