Bug#914649: libvigraimpex: FTBFS against boost1.67: undefined reference to symbol 'pthread_condattr_setclock@@GLIBC_2.4'

[Gilles Filippini]

Source: libvigraimpex
Version: 1.10.0+git20160211.167be93+dfsg-6
Severity: serious
Tags: patch ftbfs
Justification: FTBFS

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

libvigraimpex FTBFS against boost1.67 on armel [1]:

[ 19%] Linking CXX executable test_blockwisewatersheds
cd /<<BUILDDIR>>/libvigraimpex-1.10.0+git20160211.167be93+dfsg/obj/test/blockwisealgorithms && /usr/bin/cmake -E cmake_link_script CMakeFiles/test_blockwisewatersheds.dir/link.txt --verbose=1
/usr/bin/c++  -W -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-unused-variable -Wno-type-limits -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/libvigraimpex-1.10.0+git20160211.167be93+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -pipe -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++11  -rdynamic CMakeFiles/test_blockwisewatersheds.dir/test_watersheds.cxx.o CMakeFiles/test_blockwisewatersheds.dir/testsuccess.cxx.o  -o test_blockwisewatersheds -lboost_thread -lboost_system -lboost_date_time -lboost_chrono 
/usr/bin/ld: CMakeFiles/test_blockwisewatersheds.dir/test_watersheds.cxx.o: undefined reference to symbol 'pthread_condattr_setclock@@GLIBC_2.4'
/usr/bin/ld: //lib/arm-linux-gnueabi/libpthread.so.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

[1] https://buildd.debian.org/status/fetch.php?pkg=libvigraimpex&arch=armel&ver=1.10.0%2Bgit20160211.167be93%2Bdfsg-6%2Bb2&stamp=1542723257&raw=0

Not sure about the Good Way of solving this, but the attached patch is successful as a workaround (tested on armel and amd64).

Thanks,

_g.

- -- System Information:
Debian Release: buster/sid
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.14.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEoJObzArDE05WtIyR7+hsbH/+z4MFAlv7H6QACgkQ7+hsbH/+
z4O6EQf/XBfegp9DOLxippoKKUv0XBuUI89BY3GwMbH5hYJBB1kCSaSE4t0gJxqs
dPel3rXn+O3uQVtNjzKNFYEfjU5cq2mT2vT5lSxPkUroA/XXhwZa+UTxYW76Mphr
J7FzfZAp+/d0tKW0Y1gzp1D6w5F7mNA9vw+SyhAUe0QTlNOEFZmAKsg73gc34pWe
x3n8sK8KWHlfo7HsFYmvq2CbIHbCZ/4FJ1k07GjRMCzTqQL5dT6itRbeXA/ly+Co
KYGx3NJYvioRRHkoGm/FKzrgWP7PhofKTgwMVZ6UQq4wTjjpjltUU72I52+Gfnb3
zjpEO/8tROT9uSJAFTEBVpsLT6Qzkg==
=Lpjx
-----END PGP SIGNATURE-----
-------------- next part --------------
diff -Nru libvigraimpex-1.10.0+git20160211.167be93+dfsg/debian/changelog libvigraimpex-1.10.0+git20160211.167be93+dfsg/debian/changelog
--- libvigraimpex-1.10.0+git20160211.167be93+dfsg/debian/changelog	2018-08-11 06:20:04.000000000 +0200
+++ libvigraimpex-1.10.0+git20160211.167be93+dfsg/debian/changelog	2018-11-25 20:43:26.000000000 +0100
@@ -1,3 +1,10 @@
+libvigraimpex (1.10.0+git20160211.167be93+dfsg-6.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * New patch link-with-pthread.patch to fix FTBFS against boost1.67 on armel
+
+ -- Gilles Filippini <pini at debian.org>  Sun, 25 Nov 2018 20:43:26 +0100
+
 libvigraimpex (1.10.0+git20160211.167be93+dfsg-6) unstable; urgency=medium
 
   * add multi_convolution_fix_incomplete_template_paramater.patch
diff -Nru libvigraimpex-1.10.0+git20160211.167be93+dfsg/debian/patches/link-with-pthread.patch libvigraimpex-1.10.0+git20160211.167be93+dfsg/debian/patches/link-with-pthread.patch
--- libvigraimpex-1.10.0+git20160211.167be93+dfsg/debian/patches/link-with-pthread.patch	1970-01-01 01:00:00.000000000 +0100
+++ libvigraimpex-1.10.0+git20160211.167be93+dfsg/debian/patches/link-with-pthread.patch	2018-11-25 20:43:26.000000000 +0100
@@ -0,0 +1,13 @@
+Index: libvigraimpex-1.10.0+git20160211.167be93+dfsg/config/VigraConfigureThreading.cmake
+===================================================================
+--- libvigraimpex-1.10.0+git20160211.167be93+dfsg.orig/config/VigraConfigureThreading.cmake
++++ libvigraimpex-1.10.0+git20160211.167be93+dfsg/config/VigraConfigureThreading.cmake
+@@ -9,7 +9,7 @@ macro(VIGRA_CONFIGURE_THREADING)
+     set(THREADING_FOUND 1)
+     if(THREADING_IMPLEMENTATION MATCHES "boost")
+         include_directories(${Boost_INCLUDE_DIR})
+-        set(THREADING_LIBRARIES ${Boost_THREAD_LIBRARY} ${Boost_SYSTEM_LIBRARY} ${Boost_DATE_TIME_LIBRARY} ${Boost_CHRONO_LIBRARY})
++        set(THREADING_LIBRARIES ${Boost_THREAD_LIBRARY} ${Boost_SYSTEM_LIBRARY} ${Boost_DATE_TIME_LIBRARY} ${Boost_CHRONO_LIBRARY} pthread)
+     elseif(THREADING_IMPLEMENTATION MATCHES "std")
+         # Great, we can use the std library.  Nothing to do here...
+     elseif(THREADING_IMPLEMENTATION MATCHES "none")
diff -Nru libvigraimpex-1.10.0+git20160211.167be93+dfsg/debian/patches/series libvigraimpex-1.10.0+git20160211.167be93+dfsg/debian/patches/series
--- libvigraimpex-1.10.0+git20160211.167be93+dfsg/debian/patches/series	2018-08-11 06:18:32.000000000 +0200
+++ libvigraimpex-1.10.0+git20160211.167be93+dfsg/debian/patches/series	2018-11-25 20:43:26.000000000 +0100
@@ -7,3 +7,4 @@
 removed-static-docs.diff
 const-swap.patch
 multi_convolution_fix_incomplete_template_paramater.patch
+link-with-pthread.patch