Bug#909906: jh_installlibs --version-strip="+.*": Quantifier follows nothing in regex

[Niels Thykier]

On Sat, 29 Sep 2018 20:47:00 +0000 Niels Thykier <niels at thykier.net> wrote:
> clone 909906 -1
> reassign -1 jython
> reassign 909906 jsurf-alggeo
> retitle -1 jython: Invalid regex passed to jh_installlibs
> retitle 909906 jsurf-alggeo: Invalid regex passed to jh_installlibs
> thanks,
> 
> Adrian Bunk:
> > Package: javatools
> > Version: 0.66
> > Severity: serious
> > Control: affects -1 src:jython
> > 
> > https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/jython.html
> > 
> > ...
> >    debian/rules override_jh_installlibs
> > make[1]: Entering directory '/build/1st/jython-2.7.1+repack'
> > jh_installlibs --version-strip="+.*"
> > Quantifier follows nothing in regex; marked by <-- HERE in m/+ <-- HERE .*/ at /usr/bin/jh_installlibs line 111.
> > make[1]: *** [debian/rules:89: override_jh_installlibs] Error 25
> > 
> 
> The shell version of jh_installlibs used sed which is apparently more
> forgiving (or possibly does not handle "+" like perl does).  Attempting
> to emulate sed's behaviour will never be a perfect match.
> 
> Maintainers of jython and jsurf-alggeo: You presumably wanted to match a
> literal "+", in which case please escape it (by using e.g. [+] like the
> htsjdk package).
> 
>  * The jython variant then becomes --version-strip="[+].*"
>  * The jsurf-alggeo variant becomes --version-strip="[+]ds"
> 
> Thanks,
> ~Niels
> 
> 

Btw, the default regex for jh_installlibs is: [\.+~-]ds(?:fg)?[0-9]*

It looks like it might be sufficient to replace the need for passing the
--version-strip option.

Thanks,
~Niels