Bug#945389: Tried to upgrade skimage to see whether #945389 is fixed but failed

[Andreas Tille]

Hi Stefan,

thanks a lot for your feedback.

On Tue, Dec 03, 2019 at 12:38:24PM -0800, Stefan van der Walt wrote:
> The problem here stems from an old version of Cython.  My recommended approach would be to build from the git tag instead of the source tarball (i.e., the version without pre-generated Cython files).

Hmmm, I think the Cython files are generated in the build I did.  The
build log says:

...
   dh_auto_configure -O--buildsystem=pybuild
I: pybuild base:217: python3.8 setup.py config.
Compiling /build/skimage-0.16.2/skimage/_shared/geometry.pyx because it changed.
Compiling /build/skimage-0.16.2/skimage/_shared/transform.pyx because it changed.
Compiling /build/skimage-0.16.2/skimage/_shared/interpolation.pyx because it changed.
Partial import of skimage during the build process.
[1/3] Cythonizing /build/skimage-0.16.2/skimage/_shared/geometry.pyx
[3/3] Cythonizing /build/skimage-0.16.2/skimage/_shared/transform.pyx
[2/3] Cythonizing /build/skimage-0.16.2/skimage/_shared/interpolation.pyx
Compiling /build/skimage-0.16.2/skimage/draw/_draw.pyx because it changed.
[1/1] Cythonizing /build/skimage-0.16.2/skimage/draw/_draw.pyx
Compiling /build/skimage-0.16.2/skimage/feature/corner_cy.pyx because it changed.
Compiling /build/skimage-0.16.2/skimage/feature/censure_cy.pyx because it changed.
Compiling /build/skimage-0.16.2/skimage/feature/orb_cy.pyx because it changed.
Compiling /build/skimage-0.16.2/skimage/feature/brief_cy.pyx because it changed.
Compiling /build/skimage-0.16.2/skimage/feature/_texture.pyx because it changed.
Compiling /build/skimage-0.16.2/skimage/feature/_hessian_det_appx.pyx because it changed.
Compiling /build/skimage-0.16.2/skimage/feature/_hoghistogram.pyx because it changed.
[4/7] Cythonizing /build/skimage-0.16.2/skimage/feature/brief_cy.pyx
[5/7] Cythonizing /build/skimage-0.16.2/skimage/feature/censure_cy.pyx
[1/7] Cythonizing /build/skimage-0.16.2/skimage/feature/_hessian_det_appx.pyx
[6/7] Cythonizing /build/skimage-0.16.2/skimage/feature/corner_cy.pyx
[3/7] Cythonizing /build/skimage-0.16.2/skimage/feature/_texture.pyx
[2/7] Cythonizing /build/skimage-0.16.2/skimage/feature/_hoghistogram.pyx
[7/7] Cythonizing /build/skimage-0.16.2/skimage/feature/orb_cy.pyx
...

> I don't think the Cython-related patches that were applied since would then be necessary.

The packaging does not contain any Cython-related patches as far as I
can see.  For the Debian packaging we usually prefer tagged releases.
While I could be convinced to derive from this principle it is not
really clear to me in how far your explanation matches the issue.  May
be its just me since I'm not so comfortable with Cython so I'd rather
ask back to make sure I understand you correctly.
 
> I will no longer be doing packaging work for scikit-image, so feel free to remove me from the maintainer list (I thought it had already been transferred to the science team a while ago).

Its correct that the _Maintainer_ is set to Debian Science team.  But
the actual members of the team (in Debian terminology the _Uploaders_)
are you and Yaroslav.  I just pushed the following commit:

$ git diff HEAD^
diff --git a/debian/changelog b/debian/changelog
index 4baf3e7e..e294c4bf 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,8 @@ skimage (0.16.2-1) UNRELEASED; urgency=medium
   * New upstream version
   * Standards-Version: 4.4.1
   * More default d/rules
+  * Drop Stefan van der Walt from Uploaders since he confirmed not to
+    do packaging work any more (thanks for your previous work Stefan)
 
  -- Andreas Tille <tille at debian.org>  Mon, 02 Dec 2019 10:07:39 +0100
 
diff --git a/debian/control b/debian/control
index deee0d75..bd692cc2 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,6 @@
 Source: skimage
 Maintainer: Debian Science Maintainers <debian-science-maintainers at lists.alioth.debian.org>
-Uploaders: Stefan van der Walt <stefanv at berkeley.edu>,
-           Yaroslav Halchenko <debian at onerussian.com>
+Uploaders: Yaroslav Halchenko <debian at onerussian.com>
 Section: python
 Priority: optional
 Build-Depends: cython3 (>= 0.23),


Kind regards,

     Andreas. 

-- 
http://fam-tille.de