Bug#947280: src:paraview: FTBFS on armel an mipsel: undefined reference to `__atomic_fetch_add_8'

[Gilles Filippini]

Package: src:paraview
Version: 5.7.0-3
Severity: serious
Tags: patch
Justification: FTBFS

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

The same error is spotted in the logs of failed paraview 5.7.0 builds for
armel[1] and mipsel[2]:
/usr/bin/ld: ../../../../lib/mipsel-linux-gnu/libvtkprotobuf-pv5.7.so.5.7: undefined reference to `__atomic_fetch_add_8'

[1] https://buildd.debian.org/status/fetch.php?pkg=paraview&arch=armel&ver=5.7.0-3&stamp=1576169428&raw=0
[2] https://buildd.debian.org/status/fetch.php?pkg=paraview&arch=mipsel&ver=5.7.0-1&stamp=1570637214&raw=0

Please find attached a patch aiming to solve this problem. Not sure it'll
be sufficient to build successfully, but it should solve this issue at
least.

Thanks,

_g.

- -- System Information:
Debian Release: buster/sid
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.3.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEoJObzArDE05WtIyR7+hsbH/+z4MFAl4BOnkACgkQ7+hsbH/+
z4Mb8gf/Zv+G/8fE0SNC1wR9l81HtcduHKpMzvaDV7cuk35kAMr/W60ieLqfaT7p
Z9PPgi3YD+CqElw317qbGwwxQI0VuMDxiSVKEXJsZePrg2Ff25wgy4pwSBpSjel+
9kljY0vTp0QxbO2ryZi846aH46PnQF9bppdhUocNg6igeSB/x9TUHICvyhVQ5ZNS
gKDnR5jcKlk5DIr2TRA9Xa/TEIONfoQAjGs+tNwWDYpLQnwYHQ+vT+9gL80U6MkO
jRnVKbHI0V7KQj4saoQf4eqSz2tX29hecrMQcut43YxCX3YDiomV9CxrWDWAbIOf
rzWBeG0mAHxtzdD55XqbtuN+R8jEQQ==
=z9To
-----END PGP SIGNATURE-----
-------------- next part --------------
diff -Nru paraview-5.7.0/debian/changelog paraview-5.7.0/debian/changelog
--- paraview-5.7.0/debian/changelog	2019-12-11 10:16:00.000000000 +0100
+++ paraview-5.7.0/debian/changelog	2019-12-23 22:33:43.000000000 +0100
@@ -1,3 +1,10 @@
+paraview (5.7.0-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * New patch libatomic.patch: tentative fix for FTBFS on armel and mipsel
+
+ -- Gilles Filippini <pini at debian.org>  Mon, 23 Dec 2019 22:33:43 +0100
+
 paraview (5.7.0-3) unstable; urgency=medium
 
   * Hard-code Build-Dep on python3.8-dev. This wasn't being pulled in correctly
diff -Nru paraview-5.7.0/debian/patches/libatomic.patch paraview-5.7.0/debian/patches/libatomic.patch
--- paraview-5.7.0/debian/patches/libatomic.patch	1970-01-01 01:00:00.000000000 +0100
+++ paraview-5.7.0/debian/patches/libatomic.patch	2019-12-23 22:33:43.000000000 +0100
@@ -0,0 +1,22 @@
+Index: paraview-5.7.0/ThirdParty/protobuf/vtkprotobuf/src/CMakeLists.txt
+===================================================================
+--- paraview-5.7.0.orig/ThirdParty/protobuf/vtkprotobuf/src/CMakeLists.txt
++++ paraview-5.7.0/ThirdParty/protobuf/vtkprotobuf/src/CMakeLists.txt
+@@ -312,10 +312,16 @@ if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
+   endif ()
+ endif ()
+ 
++if ((DEB_HOST_MULTIARCH STREQUAL "arm-linux-gnueabi") OR (DEB_HOST_MULTIARCH STREQUAL "mipsel-linux-gnu"))
++  set(ATOMIC_LIB atomic)
++else ()
++  set(ATOMIC_LIB "")
++endif ()
++
+ target_link_libraries(vtkprotoc
+   PRIVATE
+     ${vtkprotoc_no_as_needed}
+     vtklibprotoc
+     ParaView::protobuf
+-    Threads::Threads)
++    Threads::Threads ${ATOMIC_LIB})
+ add_executable(ParaView::protoc ALIAS vtkprotoc)
diff -Nru paraview-5.7.0/debian/patches/series paraview-5.7.0/debian/patches/series
--- paraview-5.7.0/debian/patches/series	2019-12-11 10:16:00.000000000 +0100
+++ paraview-5.7.0/debian/patches/series	2019-12-23 22:33:43.000000000 +0100
@@ -2,3 +2,4 @@
 security-format.patch
 override-fix.patch
 python3.8.patch
+libatomic.patch
diff -Nru paraview-5.7.0/debian/rules paraview-5.7.0/debian/rules
--- paraview-5.7.0/debian/rules	2019-12-11 10:16:00.000000000 +0100
+++ paraview-5.7.0/debian/rules	2019-12-23 22:33:43.000000000 +0100
@@ -73,7 +73,8 @@
 	-DPARAVIEW_ENABLE_PDAL=ON \
 	-DPARAVIEW_ENABLE_XDMF3=ON \
 	-DPARAVIEW_ENABLE_MOTIONFX=ON \
-	-DPARAVIEW_PLUGIN_ENABLE_EyeDomeLighting=ON 
+	-DPARAVIEW_PLUGIN_ENABLE_EyeDomeLighting=ON \
+	-DDEB_HOST_MULTIARCH=$(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
 
 override_dh_auto_configure:
 	dh_auto_configure -- $(extra_flags)