Bug#897722: clsparse: ftbfs with GCC-8

Rebecca N. Palmer rebecca_palmer at zoho.com
Sat Feb 2 22:01:39 GMT 2019


Control: tags -1 upstream patch
Control: forwarded -1 https://github.com/clMathLibraries/clSPARSE/pull/210

fix for this:

Description: Remove unused and unbuildable GetTypecode

This template function is unused (not in any public headers and
not called from within clSPARSE), and has always been
non-instantiable (and hence unusable) as char[4] to char& is an
invalid conversion.

Older GCC didn't check this until it was attempted, which it isn't
(instantiating a class template only instantiates those member
functions that are used), but in GCC 8 its existence is an error.

Author: Rebecca N. Palmer <rebecca_palmer at zoho.com>
Bug-Debian: https://bugs.debian.org/897722
Forwarded: https://github.com/clMathLibraries/clSPARSE/pull/210

--- a/src/benchmarks/cusparse-bench/src/mm_reader.cpp
+++ b/src/benchmarks/cusparse-bench/src/mm_reader.cpp
@@ -103,11 +103,6 @@ public:
          return isSymmetric;
      }

-    char &GetTypecode( )
-    {
-        return Typecode;
-    }
-
      Coordinate<FloatType> *GetUnsymCoordinates( )
      {
          return unsym_coords;
--- a/src/library/io/mm-reader.cpp
+++ b/src/library/io/mm-reader.cpp
@@ -118,11 +118,6 @@ public:
          return isSymmetric;
      }

-    char &GetTypecode( )
-    {
-        return Typecode;
-    }
-
      Coordinate<FloatType> *GetUnsymCoordinates( )
      {
          return unsym_coords;



More information about the debian-science-maintainers mailing list