Bug#932426: h5py: Always runs testsuite, ignores "nocheck" from DEB_BUILD_OPTIONS

[John Paul Adrian Glaubitz]

Source: h5py
Version: 2.9.0-1
Severity: normal
User: debian-68k at lists.debian.org
Usertags: m68k

Hello!

The debian/rules file of h5py overwrites the dh_auto_test target with:

override_dh_auto_test:
        set -e; for DIR in $$(find .pybuild -name build | grep -v _dbg_); do \
                cd $$DIR; PYTHONPATH=. python$$(echo $$DIR | sed -e 's at .*cpython._\(.*\)_h5py.*@\1 at g') \
                -c "from sys import exit; import h5py; exit(0) if h5py.run_tests().wasSuccessful() else exit(1)"; \
                cd ../../..; done

This means that the rules file no longer checks whether DEB_BUILD_OPTIONS
contains "nocheck" to disable the testsuite and thus the testsuite is
always run.

Could you please add an additional if condition to test whether DEB_BUILD_OPTIONS
contain "nocheck" before running the testsuite?

This should help:

override_dh_auto_test:
ifneq (nocheck,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
        set -e; for DIR in $$(find .pybuild -name build | grep -v _dbg_); do \
                cd $$DIR; PYTHONPATH=. python$$(echo $$DIR | sed -e 's at .*cpython._\(.*\)_h5py.*@\1 at g') \
                -c "from sys import exit; import h5py; exit(0) if h5py.run_tests().wasSuccessful() else exit(1)"; \
                cd ../../..; done

endif

Thanks,
Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913