Bug#925540: qhull: add libqhullcpp to installed libraries

[D Haley]

Source: qhull
Version: 2015.2-4
Severity: normal
Tags: patch

Dear Maintainer,

The Qhull package does not install the libqhullcpp shared libraries. The
headers are installed, but the library is built statically, and does
not get installed.

I have attached a patch against ea54d22bba5fb2cedf106a58bd11904370bfeb4f,
which changes the library to shared and adds it to the relevant .install
files.

If the patch or similar is not suitable, and it is not desired to
distribute the C++ library,  perhaps the C++ qhull headers should
be removed?


-- System Information:
Debian Release: 9.8
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-8-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), LANGUAGE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
>From c60f19ce512bf00ed4e735cbd513fde2a5d9e510 Mon Sep 17 00:00:00 2001
From: D Haley <mycae at gmx.com>
Date: Tue, 26 Mar 2019 14:59:11 +0000
Subject: * Fix qhullcpp not installed as .so


diff --git a/debian/libqhull-dev.install b/debian/libqhull-dev.install
index af11adb..0bdb24d 100755
--- a/debian/libqhull-dev.install
+++ b/debian/libqhull-dev.install
@@ -3,4 +3,5 @@ usr/lib/libqhull.a /usr/lib/${DEB_HOST_MULTIARCH}/
 usr/lib/libqhull.so /usr/lib/${DEB_HOST_MULTIARCH}/
 usr/lib/libqhullstatic_r.a /usr/lib/${DEB_HOST_MULTIARCH}/
 usr/lib/libqhull_r.so /usr/lib/${DEB_HOST_MULTIARCH}/
+usr/lib/libqhullcpp.so /usr/lib/${DEB_HOST_MULTIARCH}/
 usr/include
diff --git a/debian/libqhull7.install b/debian/libqhull7.install
index c6d117e..c66bdc1 100755
--- a/debian/libqhull7.install
+++ b/debian/libqhull7.install
@@ -1,2 +1,3 @@
 #! /usr/bin/dh-exec
 usr/lib/libqhull.so.* /usr/lib/${DEB_HOST_MULTIARCH}/
+usr/lib/libqhullcpp.so.* /usr/lib/${DEB_HOST_MULTIARCH}/
diff --git a/debian/patches/0004-qhullcpp-shared.patch b/debian/patches/0004-qhullcpp-shared.patch
new file mode 100644
index 0000000..14bf6dd
--- /dev/null
+++ b/debian/patches/0004-qhullcpp-shared.patch
@@ -0,0 +1,12 @@
+diff -r 4c7aa6ab184e CMakeLists.txt
+--- a/CMakeLists.txt	Wed Mar 20 22:44:13 2019 +0000
++++ b/CMakeLists.txt	Wed Mar 20 23:19:18 2019 +0000
+@@ -459,7 +459,7 @@
+ #     Do not create libqhullcpp as a shared library.  Qhull C++ classes may change layout and size. 
+ # ---------------------------------------
+ 
+-add_library(${qhull_CPP} STATIC ${libqhullcpp_SOURCES})
++add_library(${qhull_CPP} SHARED ${libqhullcpp_SOURCES})
+ set_target_properties(${qhull_CPP} PROPERTIES
+     VERSION ${qhull_VERSION})
+ 
diff --git a/debian/patches/series b/debian/patches/series
index a57e26b..1494b1a 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
 0001-debianize-test-failure-msg.patch
 0002-QHpointer.patch
 0003-spelling.patch
+0004-qhullcpp-shared.patch