Bug#940108: nexus: FTBFS with GCC 9: dereferencing pointer to incomplete type 'mxml_node_t' error

[Emmanuel Bourg]

Source: nexus
Version: 4.3.2-svn1921-6
Severity: serious
Tags: ftbfs
Justification: fails to build from source

With the Java 9 fix applied (#893383) nexus still fails to build,
I assume due to more strict checks by GCC 9:

  /bin/bash ../libtool  --tag=CC   --mode=compile x86_64-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include  -I../include -I/usr/include/hdf -DHDF4 -I/usr/lib/x86_64-linux-gnu/hdf5/serial/include -DHDF5 -DH5_NO_DEPRECATED_SYMBOLS -DH5Acreate_vers=2 -DH5Aiterate_vers=2 -DH5Dcreate_vers=2 -DH5Dopen_vers=2 -DH5Eclear_vers=2 -DH5Eprint_vers=2 -DH5Epush_vers=2 -DH5Eset_auto_vers=2 -DH5Eget_auto_vers=2 -DH5Ewalk_vers=2 -DH5Gcreate_vers=2 -DH5Gopen_vers=2 -DH5Pget_filter_vers=2 -DH5Pget_filter_by_id_vers=2 -DH5Pinsert_vers=2 -DH5Pregister_vers=2 -DH5Rget_obj_type_vers=2 -DH5Tarray_create_vers=2 -DH5Tcommit_vers=2 -DH5Tget_array_dims_vers=2 -DH5Topen_vers=2 -I/usr/include -DNXXML -DIN_NEXUS_LIBRARY=1 -Wdate-time -D_FORTIFY_SOURCE=2 -fno-common -DHAVE_NAPICONFIG_H -prefer-pic -g -O2 -fdebug-prefix-map=/build/nexus-4.3.2-svn1921=. -fstack-protector-strong -Wformat -Werror=format-security -fno-strict-aliasing -MT nxxml.lo -MD -MP -MF .deps/nxxml.Tpo -c -o nxxml.lo nxxml.c
  libtool: compile:  x86_64-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I../include -I/usr/include/hdf -DHDF4 -I/usr/lib/x86_64-linux-gnu/hdf5/serial/include -DHDF5 -DH5_NO_DEPRECATED_SYMBOLS -DH5Acreate_vers=2 -DH5Aiterate_vers=2 -DH5Dcreate_vers=2 -DH5Dopen_vers=2 -DH5Eclear_vers=2 -DH5Eprint_vers=2 -DH5Epush_vers=2 -DH5Eset_auto_vers=2 -DH5Eget_auto_vers=2 -DH5Ewalk_vers=2 -DH5Gcreate_vers=2 -DH5Gopen_vers=2 -DH5Pget_filter_vers=2 -DH5Pget_filter_by_id_vers=2 -DH5Pinsert_vers=2 -DH5Pregister_vers=2 -DH5Rget_obj_type_vers=2 -DH5Tarray_create_vers=2 -DH5Tcommit_vers=2 -DH5Tget_array_dims_vers=2 -DH5Topen_vers=2 -I/usr/include -DNXXML -DIN_NEXUS_LIBRARY=1 -Wdate-time -D_FORTIFY_SOURCE=2 -fno-common -DHAVE_NAPICONFIG_H -g -O2 -fdebug-prefix-map=/build/nexus-4.3.2-svn1921=. -fstack-protector-strong -Wformat -Werror=format-security -fno-strict-aliasing -MT nxxml.lo -MD -MP -MF .deps/nxxml.Tpo -c nxxml.c  -fPIC -DPIC -o .libs/nxxml.o
  nxxml.c: In function 'searchGroupLinks':
  nxxml.c:305:21: error: dereferencing pointer to incomplete type 'mxml_node_t' {aka 'struct _mxml_node_s'}
    305 |       if(strcmp(test->value.element.name,nxclass) == 0){
        |                     ^~
  nxxml.c: In function 'NXXmakedatatable64':
  nxxml.c:486:46: error: invalid application of 'sizeof' to incomplete type 'mxml_node_t' {aka 'struct _mxml_node_s'}
    486 |       newData = (mxml_node_t *)malloc(sizeof(mxml_node_t));
        |                                              ^~~~~~~~~~~
  nxxml.c:491:31: error: invalid application of 'sizeof' to incomplete type 'mxml_node_t' {aka 'struct _mxml_node_s'}
    491 |       memset(newData,0,sizeof(mxml_node_t));
        |                               ^~~~~~~~~~~
  nxxml.c: In function 'NXXmakedata64':
  nxxml.c:555:44: error: invalid application of 'sizeof' to incomplete type 'mxml_node_t' {aka 'struct _mxml_node_s'}
    555 |     newData = (mxml_node_t *)malloc(sizeof(mxml_node_t));
        |                                            ^~~~~~~~~~~
  nxxml.c:560:29: error: invalid application of 'sizeof' to incomplete type 'mxml_node_t' {aka 'struct _mxml_node_s'}
    560 |     memset(newData,0,sizeof(mxml_node_t));
        |                             ^~~~~~~~~~~
  make[2]: *** [Makefile:606: nxxml.lo] Error 1