Bug#957804: skinedit: ftbfs with GCC-10

[Matthias Klose]

Package: src:skinedit
Version: 1.27-3
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/skinedit_1.27-3_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
  128 |   sbar_print(_("Skin exported as %s (%s)"), ((version == EXPORT_VTI_2_1) ? "VTiv2.1" : "VTiv2.5"), g_basename(path));
      |   ^~~~~~~~~~
In file included from /usr/include/glib-2.0/glib.h:48,
                 from vti_export.c:33:
/usr/include/glib-2.0/glib/gfileutils.h:163:14: note: declared here
  163 | const gchar *g_basename         (const gchar *file_name);
      |              ^~~~~~~~~~
In file included from /usr/include/string.h:495,
                 from vti_export.c:27:
In function ‘strncpy’,
    inlined from ‘export_skin_vti’ at vti_export.c:101:6:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ specified bound 64 equals destination size [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘strncpy’,
    inlined from ‘export_skin_vti’ at vti_export.c:108:6:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ specified bound 64 equals destination size [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘strncpy’,
    inlined from ‘export_skin_vti’ at vti_export.c:90:6:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ specified bound 64 equals destination size [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/bin/bash ../libtool  --tag=CC   --mode=link gcc -Wall -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security  -Wl,-z,relro -o skinedit skinedit-main.o skinedit-support.o skinedit-main_intf.o skinedit-main_cb.o skinedit-boxes_intf.o skinedit-boxes_cb.o skinedit-prop_intf.o skinedit-prop_cb.o skinedit-rubberbox.o skinedit-skinops.o skinedit-utils.o skinedit-vti_export.o -lglib-2.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype  
libtool: link: gcc -Wall -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -o skinedit skinedit-main.o skinedit-support.o skinedit-main_intf.o skinedit-main_cb.o skinedit-boxes_intf.o skinedit-boxes_cb.o skinedit-prop_intf.o skinedit-prop_cb.o skinedit-rubberbox.o skinedit-skinops.o skinedit-utils.o skinedit-vti_export.o  -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype
/usr/bin/ld: skinedit-main_intf.o:./src/main_intf.h:10: multiple definition of `drawingarea1'; skinedit-main.o:./src/main_intf.h:10: first defined here
/usr/bin/ld: skinedit-main_intf.o:./src/main_intf.h:11: multiple definition of `statusbar'; skinedit-main.o:./src/main_intf.h:11: first defined here
/usr/bin/ld: skinedit-main_intf.o:./src/main_intf.h:13: multiple definition of `pixbuf'; skinedit-main.o:./src/main_intf.h:13: first defined here
/usr/bin/ld: skinedit-main_cb.o:./src/main_intf.h:13: multiple definition of `pixbuf'; skinedit-main.o:./src/main_intf.h:13: first defined here
/usr/bin/ld: skinedit-main_cb.o:./src/main_intf.h:10: multiple definition of `drawingarea1'; skinedit-main.o:./src/main_intf.h:10: first defined here
/usr/bin/ld: skinedit-main_cb.o:./src/main_intf.h:11: multiple definition of `statusbar'; skinedit-main.o:./src/main_intf.h:11: first defined here
/usr/bin/ld: skinedit-boxes_intf.o:./src/boxes_intf.h:9: multiple definition of `list_keys_dialog'; skinedit-main_cb.o:./src/boxes_intf.h:9: first defined here
/usr/bin/ld: skinedit-boxes_cb.o:./src/main_intf.h:10: multiple definition of `drawingarea1'; skinedit-main.o:./src/main_intf.h:10: first defined here
/usr/bin/ld: skinedit-boxes_cb.o:./src/rubberbox.h:40: multiple definition of `clist_row'; skinedit-main_cb.o:./src/rubberbox.h:40: first defined here
/usr/bin/ld: skinedit-boxes_cb.o:./src/boxes_intf.h:9: multiple definition of `list_keys_dialog'; skinedit-main_cb.o:./src/boxes_intf.h:9: first defined here
/usr/bin/ld: skinedit-boxes_cb.o:./src/rubberbox.h:41: multiple definition of `clist_max'; skinedit-main_cb.o:./src/rubberbox.h:41: first defined here
/usr/bin/ld: skinedit-boxes_cb.o:./src/main_intf.h:13: multiple definition of `pixbuf'; skinedit-main.o:./src/main_intf.h:13: first defined here
/usr/bin/ld: skinedit-boxes_cb.o:./src/main_intf.h:11: multiple definition of `statusbar'; skinedit-main.o:./src/main_intf.h:11: first defined here
/usr/bin/ld: skinedit-prop_cb.o:./src/rubberbox.h:41: multiple definition of `clist_max'; skinedit-main_cb.o:./src/rubberbox.h:41: first defined here
/usr/bin/ld: skinedit-prop_cb.o:./src/rubberbox.h:40: multiple definition of `clist_row'; skinedit-main_cb.o:./src/rubberbox.h:40: first defined here
/usr/bin/ld: skinedit-prop_cb.o:./src/boxes_intf.h:9: multiple definition of `list_keys_dialog'; skinedit-main_cb.o:./src/boxes_intf.h:9: first defined here
/usr/bin/ld: skinedit-prop_cb.o:./src/main_intf.h:13: multiple definition of `pixbuf'; skinedit-main.o:./src/main_intf.h:13: first defined here
/usr/bin/ld: skinedit-prop_cb.o:./src/main_intf.h:11: multiple definition of `statusbar'; skinedit-main.o:./src/main_intf.h:11: first defined here
/usr/bin/ld: skinedit-prop_cb.o:./src/main_intf.h:10: multiple definition of `drawingarea1'; skinedit-main.o:./src/main_intf.h:10: first defined here
/usr/bin/ld: skinedit-rubberbox.o:./src/main_intf.h:13: multiple definition of `pixbuf'; skinedit-main.o:./src/main_intf.h:13: first defined here
/usr/bin/ld: skinedit-rubberbox.o:./src/rubberbox.h:40: multiple definition of `clist_row'; skinedit-main_cb.o:./src/rubberbox.h:40: first defined here
/usr/bin/ld: skinedit-rubberbox.o:./src/rubberbox.h:41: multiple definition of `clist_max'; skinedit-main_cb.o:./src/rubberbox.h:41: first defined here
/usr/bin/ld: skinedit-rubberbox.o:./src/boxes_intf.h:9: multiple definition of `list_keys_dialog'; skinedit-main_cb.o:./src/boxes_intf.h:9: first defined here
/usr/bin/ld: skinedit-rubberbox.o:./src/main_intf.h:10: multiple definition of `drawingarea1'; skinedit-main.o:./src/main_intf.h:10: first defined here
/usr/bin/ld: skinedit-rubberbox.o:./src/main_intf.h:11: multiple definition of `statusbar'; skinedit-main.o:./src/main_intf.h:11: first defined here
/usr/bin/ld: skinedit-skinops.o:./src/main_intf.h:13: multiple definition of `pixbuf'; skinedit-main.o:./src/main_intf.h:13: first defined here
/usr/bin/ld: skinedit-skinops.o:./src/main_intf.h:10: multiple definition of `drawingarea1'; skinedit-main.o:./src/main_intf.h:10: first defined here
/usr/bin/ld: skinedit-skinops.o:./src/skinops.c:367: multiple definition of `main_wnd'; skinedit-main.o:./src/main.c:31: first defined here
/usr/bin/ld: skinedit-skinops.o:./src/main_intf.h:11: multiple definition of `statusbar'; skinedit-main.o:./src/main_intf.h:11: first defined here
/usr/bin/ld: skinedit-utils.o:./src/main_intf.h:11: multiple definition of `statusbar'; skinedit-main.o:./src/main_intf.h:11: first defined here
/usr/bin/ld: skinedit-utils.o:./src/main_intf.h:13: multiple definition of `pixbuf'; skinedit-main.o:./src/main_intf.h:13: first defined here
/usr/bin/ld: skinedit-utils.o:./src/main_intf.h:10: multiple definition of `drawingarea1'; skinedit-main.o:./src/main_intf.h:10: first defined here
/usr/bin/ld: skinedit-skinops.o: in function `load_image':
./src/skinops.c:381: warning: the use of `mktemp' is dangerous, better use `mkstemp' or `mkdtemp'
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:452: skinedit] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:436: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:368: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2