Bug#976424: vtk6: FTBFS in sid

[Gianfranco Costamagna]

Source: vtk6
Version: 6.3.0+dfsg2-5
Severity: serious
tags: patch

Hello, looks like vtk6 started FTBFS in sid, not sure if this is just a matter of including QtPainterPath or something else is needed

This patch seems to fix the issue, however, vtk7 and vtk9 have the very same code and they looks not failing...

--- vtk6-6.3.0+dfsg2.orig/Rendering/Qt/vtkQtLabelRenderStrategy.cxx
+++ vtk6-6.3.0+dfsg2/Rendering/Qt/vtkQtLabelRenderStrategy.cxx
@@ -34,6 +34,7 @@
 #include "vtkTextureMapToPlane.h"
 #include "vtkTimerLog.h"

+#include <QPainterPath>
 #include <QApplication>
 #include <QFont>
 #include <QFontMetrics>
--- vtk6-6.3.0+dfsg2.orig/Rendering/Qt/vtkQtStringToImage.cxx
+++ vtk6-6.3.0+dfsg2/Rendering/Qt/vtkQtStringToImage.cxx
@@ -25,6 +25,7 @@
 #include "vtkObjectFactory.h"

 // Qt classes
+#include <QPainterPath>
 #include <QApplication>
 #include <QString>
 #include <QFont>



This is an example of failure log
libvtkCommonMath-6.3.so.6.3.0 ../../lib/libvtkCommonSystem-6.3.so.6.3.0 ../../lib/libvtkCommonCore-6.3.so.6.3.0 -Wl,-rpath-link,/<<PKGBUILDDIR>>/debian/build/lib 
/<<PKGBUILDDIR>>/Rendering/Qt/vtkQtStringToImage.cxx: In member function ‘virtual vtkVector2i vtkQtStringToImage::GetBounds(vtkTextProperty*, const vtkUnicodeString&, int)’:
/<<PKGBUILDDIR>>/Rendering/Qt/vtkQtStringToImage.cxx:109:16: error: aggregate ‘QPainterPath path’ has incomplete type and cannot be defined
  109 |   QPainterPath path;
      |                ^~~~
/<<PKGBUILDDIR>>/Rendering/Qt/vtkQtStringToImage.cxx: In member function ‘virtual vtkVector2i vtkQtStringToImage::GetBounds(vtkTextProperty*, const vtkStdString&, int)’:
/<<PKGBUILDDIR>>/Rendering/Qt/vtkQtStringToImage.cxx:140:16: error: aggregate ‘QPainterPath path’ has incomplete type and cannot be defined
  140 |   QPainterPath path;
      |                ^~~~
/<<PKGBUILDDIR>>/Rendering/Qt/vtkQtStringToImage.cxx: In member function ‘virtual int vtkQtStringToImage::RenderString(vtkTextProperty*, const vtkUnicodeString&, int, vtkImageData*, int*)’:
/<<PKGBUILDDIR>>/Rendering/Qt/vtkQtStringToImage.cxx:187:16: error: aggregate ‘QPainterPath path’ has incomplete type and cannot be defined
  187 |   QPainterPath path;
      |                ^~~~
make[3]: *** [Rendering/Qt/CMakeFiles/vtkRenderingQt.dir/build.make:124: Rendering/Qt/CMakeFiles/vtkRenderingQt.dir/vtkQtStringToImage.cxx.o] Error 1
make[3]: *** Waiting for unfinished jobs....
/<<PKGBUILDDIR>>/Rendering/Qt/vtkQtLabelRenderStrategy.cxx: In member function ‘virtual void vtkQtLabelRenderStrategy::ComputeLabelBounds(vtkTextProperty*, vtkUnicodeString, double*)’:
/<<PKGBUILDDIR>>/Rendering/Qt/vtkQtLabelRenderStrategy.cxx:271:18: error: aggregate ‘QPainterPath path’ has incomplete type and cannot be defined
  271 |     QPainterPath path;
      |                  ^~~~
/<<PKGBUILDDIR>>/Rendering/Qt/vtkQtLabelRenderStrategy.cxx: In member function ‘virtual void vtkQtLabelRenderStrategy::RenderLabel(int*, vtkTextProperty*, vtkUnicodeString, int)’:
/<<PKGBUILDDIR>>/Rendering/Qt/vtkQtLabelRenderStrategy.cxx:373:16: error: aggregate ‘QPainterPath path’ has incomplete type and cannot be defined
  373 |   QPainterPath path;
      |                ^~~~
/<<PKGBUILDDIR>>/Rendering/Qt/vtkQtLabelRenderStrategy.cxx: In member function ‘virtual void vtkQtLabelRenderStrategy::RenderLabel(int*, vtkTextProperty*, vtkUnicodeString)’:
/<<PKGBUILDDIR>>/Rendering/Qt/vtkQtLabelRenderStrategy.cxx:484:18: error: aggregate ‘QPainterPath path’ has incomplete type and cannot be defined
  484 |     QPainterPath path;
      |                  ^~~~
make[3]: *** [Rendering/Qt/CMakeFiles/vtkRenderingQt.dir/build.make:111: Rendering/Qt/CMakeFiles/vtkRenderingQt.dir/vtkQtLabelRenderStrategy.cxx.o] Error 1
cd /<<PKGBUILDDIR>>/debian/build/Interaction/Widgets && /usr/bin/cmake -E cmake_symlink_library ../../lib/libvtkInteractionWidgets-6.3.so.6.3.0 ../../lib/libvtkInteractionWidgets-6.3.so.6.3 ../../lib/libvtkInteractionWidgets-6.3.so
make[3]: Leaving directory '/<<PKGBUILDDIR>>/debian/build'
[ 96%] Built target vtkInteractionWidgets
make  -f Views/Core/CMakeFiles/vtkViewsCore.dir/build.make Views/Core/CMakeFiles/vtkViewsCore.dir/depend

Can you please have a look?

G.