hfst_3.15.3-1_amd64.changes REJECTED

[Joerg Jaspert]

Hi Maintainer,

sorry, rejected this time around.

The review notes from one trainee are below:

Comments
========

[ d/c : debian/copyright ]

/ ***** serious error *****/

- back-ends/foma/cpp-version/apply.cc mentions GNU General Public License version 2
  but d/c mentions License: Apache-2.0

  same for coaccessible.cc and many other. See Comment in the matching d/c
  stanza. I went to that page and found nothing.

  The back-ends/foma/COPYING is GPL-2.0+. The README file confirms this.

  So I guess the change to Apache-2.0 is for one future version. For this
  version, d/c is erroneous.

- back-ends/foma/cpp-version/regex.cc is Copyright (C) 1984, 1989-1990,
  2000-2011 Free Software Foundation, Inc., but d/c does not mention it.

  same for back-ends/foma/regex.[ch]

- files in back-ends/sfst/* have no copyright notice nor license notice and
  there is no COPYING or LICENSE file in the directory.

- libhfst/src/parsers/ contains files that are either GPL3 or LGPL3+ and the
  COPYING file says LGPL3 (not +) [what a mess].

- m4/ax_check_compile_flag.m4 is not mentioned in d/c.
  same for m4/ax_check_icu.m4

- scripts/windows/inttypes.h is not listed in d/c

--
bye Joerg



===

Please feel free to respond to this email if you don't understand why
your files were rejected, or if you upload new files which address our
concerns.