onnx_1.6.0+dfsg-1_amd64.changes REJECTED

[Sean Whitton]

+----------------------+
|   REJECT reasoning   |
+----------------------+

Looks like there is code from
https://stackoverflow.com/a/46204790/11767360 spread throughout a
number of different files, which is under a license which requires
attribution in d/copyright.

onnx/common/array_ref.h has different copyright holders and license.

+----------------------+
|    Other comments    |
+----------------------+

May I ask why the shlib packages are currently commented out in
d/control?  It might be worth including them in order to avoid another
trip through NEW in the near future, if you have time.

Please confirm that onnx\onnx-operators.proto and other *.proto can be
regenerated using tools included in this package (or another in the
archive).

Does all the test data really need to be installed into the binary
package?

+----------------------+
|         N.B.         |
+----------------------+

This review may not be exhaustive.  Please check your source package
against your d/copyright and the ftpmaster REJECT-FAQ, throughly,
before uploading to NEW again.

Thank you for your time and contribution!

Sean
 



===

Please feel free to respond to this email if you don't understand why
your files were rejected, or if you upload new files which address our
concerns.