Bug#964617: yade: FTBFS: GLViewer.cpp:243:93: error: ‘QString::null’ is deprecated: use QString() [-Werror=deprecated-declarations]

[Lucas Nussbaum]

Source: yade
Version: 2020.01a-8
Severity: serious
Justification: FTBFS on amd64
Tags: bullseye sid ftbfs
Usertags: ftbfs-20200709 ftbfs-bullseye

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):
> cd /<<PKGBUILDDIR>>/debian/build/gui && /usr/bin/c++  -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_CHRONO_DYN_LINK -DBOOST_DATE_TIME_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_IOSTREAMS_DYN_LINK -DBOOST_LOG_DYN_LINK -DBOOST_PYTHON_DYN_LINK -DBOOST_REGEX_DYN_LINK -DBOOST_SERIALIZATION_DYN_LINK -DBOOST_SYSTEM_DYN_LINK -DBOOST_THREAD_DYN_LINK -DMAX_LOG_LEVEL=5 -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -DSUITESPARSE_VERSION_4 -DYADE_BOOST_LOG -DYADE_FEM -DYADE_ODEINT -DYADE_POTENTIAL_PARTICLES -DYADE_SPH -D_GLViewer_EXPORTS -I/<<PKGBUILDDIR>>/debian/build/gui/_GLViewer_autogen/include -I/<<PKGBUILDDIR>> -I/usr/include/python3.8 -I/usr/lib/python3/dist-packages/numpy/core/include -I/usr/include/eigen3 -I/usr/include/vtk-6.3 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/suitesparse -I/usr/lib/x86_64-linux-gnu/openmpi/include/openmpi -I/usr/lib/x86_64-linux-gnu/openmpi/include -I/usr/lib/python3/dist-packages/mpi4py/include -I/<<PKGBUILDDIR>>/debian/build -I/usr/include/QGLViewer -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtXml -isystem /usr/include/x86_64-linux-gnu/qt5/QtOpenGL  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -Werror -Wformat -Wformat-security -Wformat-nonliteral -Wall -Wextra -Wnarrowing -Wreturn-type -Wuninitialized -Wfloat-conversion -Wcast-align -Wdisabled-optimization -Wtrampolines -Wpointer-arith -Wswitch-bool -Wwrite-strings -Wnon-virtual-dtor -Wreturn-local-addr  -Wno-error=maybe-uninitialized -Wno-comment -Wno-cast-function-type -Wno-deprecated-copy -Wshadow=compatible-local -Wno-error=cpp -fdce -fstack-protector-strong -DYADE_VTK -DYADE_OPENMP -fopenmp -DYADE_GTS  -DQGLVIEWER_FOUND -DYADE_OPENGL -DYADE_QT5  -DYADE_CGAL -DFLOW_ENGINE -DFLOW_ENGINE  -DLINSOLV -pthread -DYADE_MPI -DTWOPHASEFLOW -DYADE_GL2PS -DLBM_ENGINE -DTHERMAL -fPIC   -ftrack-macro-expansion=0 -save-temps -DEIGEN_DONT_VECTORIZE -DEIGEN_DONT_ALIGN -DEIGEN_DISABLE_UNALIGNED_ARRAY_ASSERT -DCGAL_DISABLE_ROUNDING_MATH_CHECK -frounding-math -fPIC -std=gnu++14 -o CMakeFiles/_GLViewer.dir/qt5/GLViewer.cpp.o -c /<<PKGBUILDDIR>>/gui/qt5/GLViewer.cpp
> /<<PKGBUILDDIR>>/gui/qt5/GLViewer.cpp: In member function ‘virtual void yade::GLViewer::keyPressEvent(QKeyEvent*)’:
> /<<PKGBUILDDIR>>/gui/qt5/GLViewer.cpp:243:93: error: ‘QString::null’ is deprecated: use QString() [-Werror=deprecated-declarations]
>   243 |   setStateFileName("/tmp/qglviewerState.xml"); saveStateToFile(); setStateFileName(QString::null);
>       |                                                                                             ^~~~
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject.h:47,
>                  from /usr/include/x86_64-linux-gnu/qt5/QtCore/QObject:1,
>                  from /usr/include/QGLViewer/keyFrameInterpolator.h:26,
>                  from /usr/include/QGLViewer/camera.h:26,
>                  from /usr/include/QGLViewer/qglviewer.h:26,
>                  from /<<PKGBUILDDIR>>/gui/qt5/GLViewer.hpp:12,
>                  from /<<PKGBUILDDIR>>/gui/qt5/GLViewer.cpp:11:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:913:23: note: declared here
>   913 |     static const Null null;
>       |                       ^~~~
> /<<PKGBUILDDIR>>/gui/qt5/GLViewer.cpp:243:93: error: ‘QString::null’ is deprecated: use QString() [-Werror=deprecated-declarations]
>   243 |   setStateFileName("/tmp/qglviewerState.xml"); saveStateToFile(); setStateFileName(QString::null);
>       |                                                                                             ^~~~
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject.h:47,
>                  from /usr/include/x86_64-linux-gnu/qt5/QtCore/QObject:1,
>                  from /usr/include/QGLViewer/keyFrameInterpolator.h:26,
>                  from /usr/include/QGLViewer/camera.h:26,
>                  from /usr/include/QGLViewer/qglviewer.h:26,
>                  from /<<PKGBUILDDIR>>/gui/qt5/GLViewer.hpp:12,
>                  from /<<PKGBUILDDIR>>/gui/qt5/GLViewer.cpp:11:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:913:23: note: declared here
>   913 |     static const Null null;
>       |                       ^~~~
> /<<PKGBUILDDIR>>/gui/qt5/GLViewer.cpp:247:98: error: ‘QString::null’ is deprecated: use QString() [-Werror=deprecated-declarations]
>   247 |   setStateFileName("/tmp/qglviewerState.xml"); restoreStateFromFile(); setStateFileName(QString::null);
>       |                                                                                                  ^~~~
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject.h:47,
>                  from /usr/include/x86_64-linux-gnu/qt5/QtCore/QObject:1,
>                  from /usr/include/QGLViewer/keyFrameInterpolator.h:26,
>                  from /usr/include/QGLViewer/camera.h:26,
>                  from /usr/include/QGLViewer/qglviewer.h:26,
>                  from /<<PKGBUILDDIR>>/gui/qt5/GLViewer.hpp:12,
>                  from /<<PKGBUILDDIR>>/gui/qt5/GLViewer.cpp:11:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:913:23: note: declared here
>   913 |     static const Null null;
>       |                       ^~~~
> /<<PKGBUILDDIR>>/gui/qt5/GLViewer.cpp:247:98: error: ‘QString::null’ is deprecated: use QString() [-Werror=deprecated-declarations]
>   247 |   setStateFileName("/tmp/qglviewerState.xml"); restoreStateFromFile(); setStateFileName(QString::null);
>       |                                                                                                  ^~~~
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject.h:47,
>                  from /usr/include/x86_64-linux-gnu/qt5/QtCore/QObject:1,
>                  from /usr/include/QGLViewer/keyFrameInterpolator.h:26,
>                  from /usr/include/QGLViewer/camera.h:26,
>                  from /usr/include/QGLViewer/qglviewer.h:26,
>                  from /<<PKGBUILDDIR>>/gui/qt5/GLViewer.hpp:12,
>                  from /<<PKGBUILDDIR>>/gui/qt5/GLViewer.cpp:11:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:913:23: note: declared here
>   913 |     static const Null null;
>       |                       ^~~~
> cc1plus: all warnings being treated as errors
> make[3]: *** [gui/CMakeFiles/_GLViewer.dir/build.make:79: gui/CMakeFiles/_GLViewer.dir/qt5/GLViewer.cpp.o] Error 1

The full build log is available from:
   http://qa-logs.debian.net/2020/07/09/yade_2020.01a-8_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.