Bug#975157: meshlab: FTBFS: AtomicCounter.h:28:35: error: ‘ULONG_MAX’ was not declared in this scope

[Lucas Nussbaum]

Source: meshlab
Version: 2020.06+dfsg1-1
Severity: serious
Justification: FTBFS on amd64
Tags: bullseye sid ftbfs
Usertags: ftbfs-20201119 ftbfs-bullseye

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):
> /usr/bin/c++ -DMESHLAB_SCALAR=float -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_SCRIPT_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/external-ssynth_autogen/include -I/<<PKGBUILDDIR>>/vcglib -I/<<PKGBUILDDIR>>/src -I/usr/include/eigen3 -isystem /<<PKGBUILDDIR>>/src/external/structuresynth-1.5/ssynth -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtXml -isystem /usr/include/x86_64-linux-gnu/qt5/QtOpenGL -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtScript -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -fPIC -o CMakeFiles/external-ssynth.dir/external/structuresynth-1.5/ssynth/SyntopiaCore/GLEngine/Raytracer/AtomicCounter.cpp.o -c /<<PKGBUILDDIR>>/src/external/structuresynth-1.5/ssynth/SyntopiaCore/GLEngine/Raytracer/AtomicCounter.cpp
> In file included from /<<PKGBUILDDIR>>/src/external/structuresynth-1.5/ssynth/SyntopiaCore/GLEngine/Raytracer/AtomicCounter.cpp:1:
> /<<PKGBUILDDIR>>/src/external/structuresynth-1.5/ssynth/SyntopiaCore/GLEngine/Raytracer/AtomicCounter.h:28:35: error: ‘ULONG_MAX’ was not declared in this scope
>    28 |    bool wait(unsigned long time = ULONG_MAX) { wcm.lock(); bool w = wc.wait(&wcm,time); wcm.unlock(); return w; }
>       |                                   ^~~~~~~~~
> /<<PKGBUILDDIR>>/src/external/structuresynth-1.5/ssynth/SyntopiaCore/GLEngine/Raytracer/AtomicCounter.h:5:1: note: ‘ULONG_MAX’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
>     4 | #include <QWaitCondition>
>   +++ |+#include <climits>
>     5 | 
> make[3]: *** [CMakeFiles/external-ssynth.dir/build.make:410: CMakeFiles/external-ssynth.dir/external/structuresynth-1.5/ssynth/SyntopiaCore/GLEngine/Raytracer/AtomicCounter.cpp.o] Error 1

The full build log is available from:
   http://qa-logs.debian.net/2020/11/19/meshlab_2020.06+dfsg1-1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.